Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Korean translation (lines 501-1000) #7443

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

dewble
Copy link
Contributor

@dewble dewble commented Sep 12, 2022

Issues: #7424
from: #7424 (comment)

  • Updated line number : 501-1000
  • Changed <target state="new"> to <target>
  • Translated strings to Korean, between <target state="new"> Strings to translate

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 12, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @dewble!

It looks like this is your first PR to kubernetes/dashboard 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dashboard has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added language/ko Updates or issues for Korean translations. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2022
Copy link
Member

@seokho-son seokho-son left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dewble
Thank you for the contribution !

I reviewed this PR and have minor comments. Please check the comments. :)

i18n/ko/messages.ko.xlf Outdated Show resolved Hide resolved
i18n/ko/messages.ko.xlf Outdated Show resolved Hide resolved
@seokho-son
Copy link
Member

/assign

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #7443 (58438dd) into master (e667c10) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7443   +/-   ##
=======================================
  Coverage   44.22%   44.22%           
=======================================
  Files          46       46           
  Lines        1282     1282           
  Branches      178      178           
=======================================
  Hits          567      567           
  Misses        677      677           
  Partials       38       38           

@seokho-son
Copy link
Member

Hi @shu-mutou
Please help enable workflow for this PR as well. :)
By the way, I hope to check only maintainers of this Repo can approve running workflows from first-time contributors ? (can I use a command such as /ok-to-test ?)

@seokho-son
Copy link
Member

Thanks @dewble @shu-mutou

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dewble, seokho-son

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit f547f75 into kubernetes:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ko Updates or issues for Korean translations. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants