Merge pull request #1242 from wongma7/metric-names

Automatic merge from submit-queue. Update volume operations metric names as implemented @verult PTAL, thanks! kubernetes/kubernetes#50036 (comment)
kubernetes · Oct 20, 2017 · ea50a06 · ea50a06
2 parents 66dc6df + cba0a72
commit ea50a06
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/storage/volume-metrics.md b/storage/volume-metrics.md
@@ -50,27 +50,27 @@ Following is a sample of metrics (not exhaustive) that will be added by this pro
 ```
 storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "volume_attach" }
 storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "volume_detach" }
-storage_operation_duration_seconds { volume_plugin = "glusterfs", operation_name = "provision" }
+storage_operation_duration_seconds { volume_plugin = "glusterfs", operation_name = "volume_provision" }
 storage_operation_duration_seconds { volume_plugin = "gce-pd", operation_name = "volume_delete" }
 storage_operation_duration_seconds { volume_plugin = "vsphere", operation_name = "volume_mount" }
 storage_operation_duration_seconds { volume_plugin = "iscsi" , operation_name = "volume_unmount" }
-storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "mount_device" }
 storage_operation_duration_seconds { volume_plugin = "aws-ebs", operation_name = "unmount_device" }
-storage_operation_duration_seconds { volume_plugin = "cinder" , operation_name = "verify_volume" }
+storage_operation_duration_seconds { volume_plugin = "cinder" , operation_name = "verify_volumes_are_attached" }
+storage_operation_duration_seconds { volume_plugin = "<n/a>" , operation_name = "verify_volumes_are_attached_per_node" }
 ```
 
 Similarly errors will be named:
 
 ```
 storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "volume_attach" }
 storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "volume_detach" }
-storage_operation_errors_total { volume_plugin = "glusterfs", operation_name = "provision" }
+storage_operation_errors_total { volume_plugin = "glusterfs", operation_name = "volume_provision" }
 storage_operation_errors_total { volume_plugin = "gce-pd", operation_name = "volume_delete" }
 storage_operation_errors_total { volume_plugin = "vsphere", operation_name = "volume_mount" }
 storage_operation_errors_total { volume_plugin = "iscsi" , operation_name = "volume_unmount" }
-storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "mount_device" }
 storage_operation_errors_total { volume_plugin = "aws-ebs", operation_name = "unmount_device" }
-storage_operation_errors_total { volume_plugin = "cinder" , operation_name = "verify_volume" }
+storage_operation_errors_total { volume_plugin = "cinder" , operation_name = "verify_volumes_are_attached" }
+storage_operation_errors_total { volume_plugin = "<n/a>" , operation_name = "verify_volumes_are_attached_per_node" }
 ```
 
 ### Implementation Detail