Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an e2e test that goes through dnsmasq -> kubedns -> upstream servers path #226

Closed
MrHohn opened this issue Apr 16, 2018 · 1 comment · Fixed by kubernetes/kubernetes#62832
Closed

Add an e2e test that goes through dnsmasq -> kubedns -> upstream servers path #226

MrHohn opened this issue Apr 16, 2018 · 1 comment · Fixed by kubernetes/kubernetes#62832

Comments

@MrHohn
Copy link
Member

MrHohn commented Apr 16, 2018

Ref #224, a recent regression was introduced without being caught by any of the tests. The dnsmasq -> kubedns -> upstream servers path is currently a blindspot in test and we should surely include that to prevent future regression.

cc @grayluck
@grayluck grayluck mentioned this issue Apr 19, 2018
Merged
@grayluck
Copy link
Contributor

PR created. Please take a look :)

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Apr 20, 2018
Merge pull request #62832 from grayluck/externalname-test
e85943f 
Automatic merge from submit-queue (batch tested with PRs 62885, 62832). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

e2e test forwarding externalname dns lookup to upstream nameservers.

**What this PR does / why we need it**:
e2e test forwarding externalname dns lookup to upstream nameservers.

e2e test that goes through dnsmasq -> kubedns -> upstream servers path.

Updated e2e test for PTR record lookup, test for default upstreamservers from resolv.conf.

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes kubernetes/dns#226

**Special notes for your reviewer**:
/assign @MrHohn 

**Release note**:

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

e2e test forwarding externalname dns lookup to upstream nameservers. grayluck/kubernetes
2 participants
@grayluck @MrHohn