chore(Makefile): update base image

[jchauncey]

Use the new debian-base image published to us.gcr.io/k8s-artifacts-prod instead of the old location

[k8s-ci-robot]

Welcome @jchauncey!

It looks like this is your first PR to kubernetes/dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jchauncey. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[MrHohn]

/cc @prameshj

[prameshj]

Thanks. Since this is a base-image change, could you run the script:

./image-checks.sh <image-tag> <registry-name>

after building/pushing these images to a dev registry? Just to make sure they startup correctly? Changes look good to me.

[jchauncey]

cc @justaugustus

[justaugustus]

/assign
/ok-to-test

[jchauncey]

@prameshj should that script exit cleanly? Definitely seeing some runtime errors.

Status: Downloaded newer image for upstream.azurecr.io/jochaunc/oss/kubernetes/k8s-dns-node-cache:1.15.13
iptables v1.8.2 (legacy): no command specified
Try `iptables -h' or 'iptables --help' for more information.
Verifying that node-cache binary exists in node-cache image

[prameshj]

@prameshj should that script exit cleanly? Definitely seeing some runtime errors.

Status: Downloaded newer image for upstream.azurecr.io/jochaunc/oss/kubernetes/k8s-dns-node-cache:1.15.13
iptables v1.8.2 (legacy): no command specified
Try `iptables -h' or 'iptables --help' for more information.
Verifying that node-cache binary exists in node-cache image

Those errors are fine. It will likely throw error in sidecar image too, since not all params are passed in correctly. That output looks good for node-cache image.

[prameshj]

@prameshj should that script exit cleanly? Definitely seeing some runtime errors.

Status: Downloaded newer image for upstream.azurecr.io/jochaunc/oss/kubernetes/k8s-dns-node-cache:1.15.13
iptables v1.8.2 (legacy): no command specified
Try `iptables -h' or 'iptables --help' for more information.
Verifying that node-cache binary exists in node-cache image

Those errors are fine. It will likely throw error in sidecar image too, since not all params are passed in correctly. That output looks good for node-cache image.

You can use the output of

./image-checks.sh 1.15.13 for reference.

[jchauncey]

ok yeah the errors look similar. I saw the other pr moving dns-node-cache to use debian-iptables. Is that something we should consider in this PR?

[prameshj]

ok yeah the errors look similar. I saw the other pr moving dns-node-cache to use debian-iptables. Is that something we should consider in this PR?

Good point, I have asked @champtar to comment on whether we can combine the changes.

[champtar]

iptables is fixed in iptables git master, but I'm waiting for a proper 1.8.5 release (that was supposed to happen this week), to then go talk to the debian folks to have the packages updated, to then go talk to k8s folks to updates the debian-iptables base image, to then update my PR
TLDR: don't wait for me :P

[justaugustus]

/lgtm

[prameshj]

Is this because k8s.gcr.io still points to google_containers? Can this be used for building from any location?

[jchauncey]

yeah im not sure what caused them to change the location. The us.gcr.io domain is used now for all k8s builds so Im guessing its reliable from all locations.

[prameshj]

@listx Could you confirm this is ok to use?

Once this is resolved, i think this is ok to merge.

[justaugustus]

@prameshj -- Yep. This is the US endpoint for community-hosted images now. See this tracking issue for the Debian base images: kubernetes/kubernetes#58012

The VDF (vanity domain flip for k8s.gcr.io) is being tracked here: kubernetes/release#270

The other usable endpoints are asia.gcr.io and eu.gcr.io.

[prameshj]

thanks. I see https://github.com/kubernetes/kubernetes/pull/90697/files uses the same us endpoint.

[prameshj]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jchauncey, justaugustus, prameshj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [prameshj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment