Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use formatting mode #5

Merged
merged 1 commit into from
Dec 21, 2016
Merged

Use formatting mode #5

merged 1 commit into from
Dec 21, 2016

Conversation

chentao1596
Copy link

I think we should use formatting mode rather than plus, do you think so? thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2016
@chentao1596
Copy link
Author

@bowei @MrHohn hi, cc, thank you!

@bowei
Copy link
Member

bowei commented Dec 21, 2016

can you fix your commit message to be more descriptive:

"Use string format instead of append"

@chentao1596 chentao1596 force-pushed the better-print branch 2 times, most recently from 95e1393 to 02756f5 Compare December 21, 2016 02:39
@chentao1596
Copy link
Author

@bowei Hi, i've changed it, PTAL, thank you!

@bowei bowei merged commit c91864e into kubernetes:master Dec 21, 2016
@chentao1596 chentao1596 deleted the better-print branch December 22, 2016 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants