Skip to content

Commit

Permalink
note about name of the field
Browse files Browse the repository at this point in the history
Signed-off-by: Aldo Culquicondor <acondor@google.com>
  • Loading branch information
alculquicondor committed Jan 29, 2021
1 parent d1fe3f0 commit e1bcc6e
Showing 1 changed file with 6 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,9 @@ type UncountedTerminatedPods struct {
}
```

Note: the final name of the field `uncountedTerminatedPods` will be decided
during API review.

### Algorithm

The following algorithm updates the status counters without relying on finished
Expand Down Expand Up @@ -281,9 +284,9 @@ This is different from the legacy tracking, where the Job controller does not
account for deleted Pods. This is a limitation that this KEP also wants to
solve.

However, if it's the Job controller what deletes the Pod (when parallelism
is decreased, for example), the controller removes the finalizer before
deleting it. Thus, these deletions don't count towards the failures.
However, if the Job controller deletes the Pod (when parallelism is decreased,
for example), the controller removes the finalizer before deleting it. Thus,
these deletions don't count towards the failures.

### Pod adoption

Expand Down

0 comments on commit e1bcc6e

Please sign in to comment.