Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding FailingToStart Condition in cases of configuration errors. #3815

Closed
4 tasks
kannon92 opened this issue Feb 1, 2023 · 9 comments
Closed
4 tasks

Adding FailingToStart Condition in cases of configuration errors. #3815

kannon92 opened this issue Feb 1, 2023 · 9 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/node Categorizes an issue or PR as relevant to SIG Node. wg/batch Categorizes an issue or PR as relevant to WG Batch.

Comments

@kannon92
Copy link
Contributor

kannon92 commented Feb 1, 2023

Enhancement Description

As per the discussion in kubernetes/kubernetes#113211 there is an interest in adding more information if a pod gets stuck due to a user configuaration error.

Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 1, 2023
@kannon92
Copy link
Contributor Author

kannon92 commented Feb 1, 2023

/sig node
/wg batch

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. wg/batch Categorizes an issue or PR as relevant to WG Batch. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 1, 2023
@alculquicondor
Copy link
Member

nit: FailedToStart would be enough, as it's already a Pod Condition.

@kannon92 kannon92 changed the title Adding PodFailedToStart Condition in cases of configuration errors. Adding FailedToStart Condition in cases of configuration errors. Feb 1, 2023
@kannon92 kannon92 changed the title Adding FailedToStart Condition in cases of configuration errors. Adding FailingToStart Condition in cases of configuration errors. Feb 1, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 3, 2023
@alculquicondor
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 3, 2023
@SergeyKanzhelev
Copy link
Member

@kannon92 do you plan to work on this for 1.28 release?

@kannon92
Copy link
Contributor Author

kannon92 commented May 5, 2023

@kannon92 do you plan to work on this for 1.28 release?

To be honest I feel that as a new contributor this may have been too ambitious for me.

It seems like there are still many ways this KEP could go and I could use a bit of guidance here.

I found a few other KEPs I'm leading on sig-apps that may give me some good experience but not be as daunting..

I think this KEP is useful but it seems to me that there are still too many questions to target a 1.28 implementation. The code shouldn't be too difficult but I need some way to gather more requirements on different use cases.

Do you have any suggestions on how to proceed?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024
@kannon92
Copy link
Contributor Author

kannon92 commented Feb 1, 2024

/close

I don't think I have any bandwidth on this for the future.

@k8s-ci-robot
Copy link
Contributor

@kannon92: Closing this issue.

In response to this:

/close

I don't think I have any bandwidth on this for the future.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/node Categorizes an issue or PR as relevant to SIG Node. wg/batch Categorizes an issue or PR as relevant to WG Batch.
Projects
None yet
Development

No branches or pull requests

5 participants