CRI: logging, stats, and more

[yujuhong]

Feature Description

• One-line feature description (can be used as a release note): Continue improving CRI in various aspects to better support non-docker runtimes.
• Primary contact (assignee): @yujuhong
• Responsible SIGs: sig-node
• Design proposal link (community repo):
• Link to e2e and/or unit tests:
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @Random-Liu, @mrunalp
• Approver (likely from SIG/area to which feature belongs): @dchen1107
• Feature target (which target equals to which milestone):
  • Alpha release target (x.y)
  • Beta release target (x.y)
  • Stable release target (x.y)

[idvoretskyi]

@yujuhong @dchen1107 @kubernetes/sig-node-feature-requests do you already have a defined roadmap for this feature? Any plans for 1.11?

cc @justaugustus

[justaugustus]

/assign @yujuhong

[yujuhong]

@idvoretskyi we plan to promote kubelet's log rotation feature from Alpha to Beta in 1.11.

Also, we plan to redefine the container logging path to ensure necessary metadata is captured.

[idvoretskyi]

@yujuhong perfect, thanks!

[justaugustus]

@yujuhong --
We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

[kacole2]

@yujuhong This feature was worked on in the previous milestone, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.12. This still has the beta tag as well so we need to update it accordingly.

Please update the feature target milestones on your original post as well.

If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

---

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

• Docs deadline (open placeholder PRs): 8/21
• Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

[derekwaynecarr]

we discussed this in sig-node, and we will continue to improve support. the associated feature flags are beta, and will need to still get promoted to GA.

[kacole2]

@derekwaynecarr thanks. Does this need to be tracked? Are there plans to introduce this as an alpha, beta. or GA feature in 1.12?

[justaugustus]

@yujuhong @derekwaynecarr -- just to clarify, will this feature be graduating to Beta in 1.12 or is it already Beta? Also, can you update the feature targets in the issue description?

[zparnold]

Hey there! @yujuhong I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[yujuhong]

This doesn't need to be tracked by an umbrella issue anymore.

[justaugustus]

@yujuhong -- I'm unsure of why this feature was closed. The feature targets are incomplete and updates have not been provided, so it's unclear where we stand.

Per @derekwaynecarr's comment (#552 (comment)):

we discussed this in sig-node, and we will continue to improve support. the associated feature flags are beta, and will need to still get promoted to GA.

Please provide more clarity before we decide whether or not this should be closed.

/reopen

[k8s-ci-robot]

@justaugustus: you can't re-open an issue/PR unless you authored it or you are assigned to it.

In response to this:

@yujuhong -- I'm unsure of why this feature was closed. The feature targets are incomplete and updates have not been provided, so it's unclear where we stand.

Per @derekwaynecarr's comment (#552 (comment)):

we discussed this in sig-node, and we will continue to improve support. the associated feature flags are beta, and will need to still get promoted to GA.

Please provide more clarity before we decide whether or not this should be closed.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zparnold]

@yujuhong Can you update me on the docs status when you have a sec?

[justaugustus]

@yujuhong @dchen1107 --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

[yujuhong]

We've discussed this and there will be no new change in 1.12. No documentation is needed.

[tpepper]

/milestone clear

[justaugustus]

@yujuhong -- to my previous note (#552 (comment)), no one has clarified WHY this tracking feature should be closed.

Even if work is not planned for 1.12, the feature has yet to be graduated to GA, so it needs to remain open.

Please don't close this again until we have clarification on this.

cc: @derekwaynecarr @Random-Liu @mrunalp @dchen1107

[kacole2]

Hi @yujuhong
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

Thanks!

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sftim]

Documentation issue: kubernetes/website#14956