Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pod Readiness Gates #580

Closed
freehan opened this issue Jun 26, 2018 · 23 comments
Closed

Pod Readiness Gates #580

freehan opened this issue Jun 26, 2018 · 23 comments
Assignees
@freehan @thockin
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@freehan
Copy link
Contributor

freehan commented Jun 26, 2018 •
edited
Loading

Feature Description

  • One-line feature description (can be used as a release note): Introduce extension point for external feedback on pod readiness.
  • Primary contact (assignee): freehan@
  • Responsible SIGs: sig-network
  • Design proposal link (community repo): https://github.com/kubernetes/community/blob/master/keps/sig-network/0007-pod-ready%2B%2B.md
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @yujuhong @thockin
  • Approver (likely from SIG/area to which feature belongs): @thockin
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.11)
    • Beta release target (1.12)
    • Stable release target (1.14)
@freehan freehan added sig/network Categorizes an issue or PR as relevant to SIG Network. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status kind/feature Categorizes issue or PR as related to a new feature. labels Jun 26, 2018
@freehan freehan added this to the v1.11 milestone Jun 26, 2018
@freehan freehan self-assigned this Jun 26, 2018
@justaugustus justaugustus removed this from the v1.11 milestone Jul 18, 2018
@justaugustus
Copy link
Member

This feature current has no milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.

Please note that Features Freeze is tomorrow, July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

P.S. This was sent via automation

@justaugustus justaugustus added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Aug 4, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 2, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 2, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krmayankk
Copy link

/reopen

@k8s-ci-robot
Copy link
Contributor

@krmayankk: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Jan 3, 2019
@krmayankk
Copy link

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 3, 2019
@krmayankk
Copy link

Is this being tracked still, I see the current state as 1.12 beta https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/0007-pod-ready%2B%2B.md#implementation-history

https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/#pod-readiness-gate

@kacole2
Copy link

kacole2 commented Jan 3, 2019

@krmayankk this was not tracked as a part of 1.13. Perhaps we can get some updates from feature owners on the current status. @freehan ?

@claurence
Copy link

@freehan Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

@freehan
Copy link
Contributor Author

freehan commented Jan 16, 2019 •
edited
Loading

@claurence Hi! We plan to bring it to GA in 1.14 release. There is no major change for the feature except for the flipping the flag and potential bug fix.

And we do have a KEP https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/0007-pod-ready%2B%2B.md

@claurence claurence added this to the v1.14 milestone Jan 22, 2019
@claurence claurence added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 22, 2019
@liggitt liggitt added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 31, 2019
@claurence
Copy link

@freehan the KEP is marked in a "provisional" status - what work is left to make it "implementable"? Additionally are there any open PRs in k/k that should be merged for 1.14? Code freeze is March 7th so all PRs would need to be merged by then.

@freehan
Copy link
Contributor Author

freehan commented Feb 11, 2019

Beta version of this feature has been implemented and I am aware some users are using it.

I will send an PR to update the KEP.

@thockin thockin self-assigned this Feb 15, 2019
@thockin
Copy link
Member

thockin commented Feb 15, 2019

I've done a lot of the API work on this so I am happy to review, though a cross-check might be nice.

@vishh

@jaredbhatti
Copy link

Hey folks, I'm helping out with the docs for v1.14.

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions or need additional guidance!

@freehan freehan added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Feb 22, 2019
This was referenced Feb 22, 2019
Merged
Merged
@lachie83
Copy link
Member

Hello @freehan, 1.14 enhancement shadow here. Code Freeze is March 7th and all PRs must be merged by then to your issue to make the 1.14 release. What open K/K PRs do you still have that need to merge? Thanks

@freehan
Copy link
Contributor Author

freehan commented Feb 25, 2019 •
edited
Loading

@lachie83 There is only 1 PR left to be merge kubernetes/kubernetes#74434

@spiffxp spiffxp changed the title Pod Ready++ Pod Readiness Gates Mar 27, 2019
@sergey-shambir
Copy link

@freehan the link in description is indirectly broken, can you please correct it?
Correct link: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/0007-pod-ready%2B%2B.md

This was referenced Mar 29, 2019
Closed
Closed
@kacole2
Copy link

kacole2 commented Apr 12, 2019

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@kacole2 kacole2 removed this from the v1.14 milestone Apr 12, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 12, 2019
@kacole2
Copy link

kacole2 commented Apr 12, 2019

If this went stable in 1.14, please close the issue.

@thockin
Copy link
Member

thockin commented May 2, 2019

@freehan

@freehan freehan closed this as completed May 2, 2019
@freehan
Copy link
Contributor Author

freehan commented May 2, 2019

It went GA in 1.14

@janetkuo janetkuo mentioned this issue Oct 21, 2019
Closed
@dashpole dashpole mentioned this issue Jul 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@freehan freehan

@thockin thockin

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests