Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple image types, e.g. OCI #63

Closed
21 tasks
euank opened this issue Jul 25, 2016 · 28 comments
Closed
21 tasks

Support multiple image types, e.g. OCI #63

euank opened this issue Jul 25, 2016 · 28 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@euank
Copy link

euank commented Jul 25, 2016

Description

Currently, a Kubernetes Pod's containers are assumed to be Docker images (and to use Docker's discovery).

However, with the progress of the OCI Image Spec, the inclusion of the rkt runtime (which supports docker, OCI, and ACI images), it's clear that now is a good time to consider making it possible to run additional formats.

Existing discussion of this feature have already shown demand and intent to address it eventually, just not urgency.

Ref: An old proposal, a user's request, and a bit more discussion.

This issue could also relate to generalizing image transport (ref kubernetes/kubernetes#15484), but does not necessarily have to.

Progress Tracker

  • Before Alpha
    • Write and maintain draft quality doc
      • During development keep a doc up-to-date about the desired experience of the feature and how someone can try the feature in its current state. Think of it as the README of your new feature and a skeleton for the docs to be written before the Kubernetes release. Paste link to Google Doc: DOC-LINK
    • Design Approval
      • Design Proposal. This goes under docs/proposals. Doing a proposal as a PR allows line-by-line commenting from community, and creates the basis for later design documentation. Paste link to merged design proposal here: PROPOSAL-NUMBER
      • Initial API review: PR-NUMBER
      • My Shepherd is: (waiting to be found)
      • My Secondary Contact Point is: (@euank, pending shepherd)
    • Write (code + tests + docs) then get them merged. ALL-PR-NUMBERS
      • Code needs to be disabled by default. Verified by code OWNERS
      • Minimal testing
      • Minimal docs
      • Update release notes
  • Before Beta
    • Testing is sufficient for beta
    • User docs with tutorials
      • Updated walkthrough / tutorial in the docs repo: kubernetes/kubernetes.github.io
    • Thorough API review
  • Before Stable
    • docs/proposals/foo.md moved to docs/design/foo.md
    • Soak, load testing
    • detailed user docs and examples

FEATURE_STATUS: PENDING

Note: This feature does not currently have a shepherd and it is likely it will not make the v1.4 milestone. I think tentatively marking it v1.5 and trying to get a shepherd and initial proposal a little before the v1.4 release would be a good thing to shoot for.

@philips philips added this to the v1.4 milestone Jul 25, 2016
@philips philips added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 25, 2016
@idvoretskyi
Copy link
Member

@euank @philips folks, have you found the appropriate person to be an assignee?
Are we expecting to have it in 1.4 or in 1.5 (as you mentioned in a note below)?

@soltysh
Copy link
Contributor

soltysh commented Jul 27, 2016

I might find some time to help abstracting the kubelet interface which allows accessing different runtimes.

@luxas
Copy link
Member

luxas commented Jul 29, 2016

/sub

This is interesting

@idvoretskyi
Copy link
Member

idvoretskyi commented Aug 4, 2016

@euank @philips any updates on this issue (regarding the responsible SIG, assignee and expected milestone data)?

@euank
Copy link
Author

euank commented Aug 4, 2016

Nothing yet, sorry! I'll hop on a @kubernetes/sig-apps meeting and see if they're interested and, failing at that, I can try to get together a proposal myself.

@adohe-zz
Copy link

adohe-zz commented Aug 4, 2016

/cc

@bgrant0607
Copy link
Member

@euank The original issue was kubernetes/kubernetes#7203. I can't attend SIG Apps at its current meeting time, but please notify me on any proposal and email me directly, since this presents a tricky backward-compatibility issue for the API.

@idvoretskyi
Copy link
Member

@euank thank you for the update!

@euank
Copy link
Author

euank commented Aug 17, 2016

With no takers at this point, I think this is definitely something to bump to 1.5.

We should shoot for having an initial proposal out before 1.4 ships to have a good shot at getting an alpha in 1.5.

@alex-mohr alex-mohr modified the milestones: v1.5, v1.4 Aug 17, 2016
@philips philips changed the title Support multiple image types, e.g. ACI, OCI Support multiple image types, e.g. OCI Sep 2, 2016
@dchen1107
Copy link
Member

Do we have the initial proposal ready yet?

@philips
Copy link
Contributor

philips commented Sep 20, 2016

@dchen1107 We have the old proposal: kubernetes/kubernetes#18308. CoreOS will not have time to do this work in v1.5 either. Can someone else take this up?

@idvoretskyi idvoretskyi added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Sep 29, 2016
@idvoretskyi
Copy link
Member

@dchen1107 @kubernetes/sig-node can you clarify the actual status of the feature?

@spiffxp
Copy link
Member

spiffxp commented Nov 19, 2016

@euank @idvoretskyi this needs an alpha-in-1.5, beta-in-1.5, or stable-in-1.5 label if it's going to be included in release notes for kubernetes 1.5; it has no stage listed in this spreadsheet... if it's not going into 1.5, we should remove it from that spreadsheet (yay multiple information sources)

@euank euank removed this from the v1.5 milestone Nov 19, 2016
@euank
Copy link
Author

euank commented Nov 19, 2016

De-milestoned, it didn't get picked up in this release. It can be removed from the spreadsheet.

@idvoretskyi
Copy link
Member

@euank are you going to continue working on this for the future releases?

@bgrant0607 bgrant0607 removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 20, 2017
@euank
Copy link
Author

euank commented Feb 2, 2017

I don't plan to work on this, though I'd be happy to help review/guide anyone who wants to.

@philips
Copy link
Contributor

philips commented Feb 2, 2017

Testing and supporting this should be easier now that the Amazon ECR product publicly support OCI Image Spec: https://groups.google.com/a/opencontainers.org/d/msg/dev/ajYuSUnHhXY/ZRMd7XuNBQAJ

@idvoretskyi
Copy link
Member

@euank any progress is expected on this feature? If yes, please update the feature description with the new template.

@idvoretskyi idvoretskyi added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label May 3, 2017
@luxas
Copy link
Member

luxas commented May 4, 2017

@euank Is this relevant anymore with CRI?

@euank
Copy link
Author

euank commented May 4, 2017

Yes, it's relevant. It's entirely independent of CRI.

I'm not currently working on it nor do I know of anyone who is, but with the OCI image spec nearing 1.0, it's possible this'll be more important, cc @philips

@idvoretskyi
Copy link
Member

So, any updates on this? Is the progress still expected or this issue has to be closed? @kubernetes/sig-node-feature-requests @calebamiles

@idvoretskyi idvoretskyi added this to the next-milestone milestone May 31, 2017
@philips
Copy link
Contributor

philips commented Jul 19, 2017

Update on this, OCI has hit v1.0: https://www.opencontainers.org/blog/2017/07/19/oci-v1-0-bringing-containers-closer-to-standardization

@idvoretskyi
Copy link
Member

@philips woohoo!

Will this feature be updated for 1.8?

@philips
Copy link
Contributor

philips commented Aug 11, 2017

@idvoretskyi Someone needs to do the work to make APIs take an image type field or content-type.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 2, 2018
@yujuhong yujuhong added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 2, 2018
@idvoretskyi
Copy link
Member

@yujuhong are you expecting any progress on this feature?

@yujuhong
Copy link
Contributor

@yujuhong are you expecting any progress on this feature?

Nope. The feature has not been implemented yet, so I removed the lifecycle/stale label.
If the policy of the features repository is to not keep inactive (i.e., not being actively worked on) features, feel free to close this instead.

@idvoretskyi
Copy link
Member

@yujuhong correct, we'd like to keep here only actively developed features.

Closing now, feel free to reopen anytime when you'll be ready.

ingvagabund pushed a commit to ingvagabund/enhancements that referenced this issue Apr 2, 2020
add global cluster egress proxy enhancement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests