Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test plan for startupProbe #1037

Merged
merged 2 commits into from
May 28, 2019
Merged

Add test plan for startupProbe #1037

merged 2 commits into from
May 28, 2019

Conversation

matthyx
Copy link
Contributor

@matthyx matthyx commented May 2, 2019

Adding test plan to meet implementable requirements.
/cc @thockin
/cc @mrbobbytables

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2019
@mrbobbytables
Copy link
Member

Thank you @matthyx 👍
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2019
@mrbobbytables
Copy link
Member

/assign @derekwaynecarr
Just following up from previous KEP sign off in #1014 (comment)

@mrbobbytables
Copy link
Member

@derekwaynecarr gentle reminder ping :)

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 18, 2019
@matthyx
Copy link
Contributor Author

matthyx commented May 18, 2019

@derekwaynecarr I have updated the design and linked relevant PRs... I think it might be wise to merge at this moment.

@derekwaynecarr
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, matthyx, mrbobbytables

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6879726 into kubernetes:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrbobbytables mrbobbytables Awaiting requested review from mrbobbytables

@thockin thockin Awaiting requested review from thockin

Assignees

@derekwaynecarr derekwaynecarr

@mrbobbytables mrbobbytables

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthyx @mrbobbytables @derekwaynecarr @k8s-ci-robot