Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtimeclass scheduling updates #1069

Merged
merged 2 commits into from
May 31, 2019

Conversation

tallclair
Copy link
Member

Follow ups from the RuntimeClass scheduling API / architecture review. Concerns raised in the review:

  • The term Topology is too ambiguous and overloaded
  • @thockin was concerned about adding new special cased scheduler predicates.

This update addresses those concerns by:

  • Renaming Topology to Scheduling
  • Replacing the corev1.NodeSelector type with map[string]string. This makes the merging logic much simpler, so we can mix in the node selector in admission and leave the scheduler untouched. If we find a need for the more complicated node selector logic in the future, we can revisit this decision with an additional field.

/assign @thockin @dchen1107 @bsalamat @yastij
/sig node
/milestone v1.15
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label May 20, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 20, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 20, 2019
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 20, 2019
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

As we can still express constrains using nodeSelector and tolerations

@thockin
Copy link
Member

thockin commented May 29, 2019

Thanks!

/approve

@thockin thockin added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: tallclair, thockin, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 02d49b9 into kubernetes:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants