-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtimeclass scheduling updates #1069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
As we can still express constrains using nodeSelector and tolerations
Thanks! /approve |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: tallclair, thockin, yastij The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Follow ups from the RuntimeClass scheduling API / architecture review. Concerns raised in the review:
Topology
is too ambiguous and overloadedThis update addresses those concerns by:
Topology
toScheduling
corev1.NodeSelector
type withmap[string]string
. This makes the merging logic much simpler, so we can mix in the node selector in admission and leave the scheduler untouched. If we find a need for the more complicated node selector logic in the future, we can revisit this decision with an additional field./assign @thockin @dchen1107 @bsalamat @yastij
/sig node
/milestone v1.15
/priority important-soon