Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move kubernetes/community#2314 to a KEP. #1190

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Move kubernetes/community#2314 to a KEP. #1190

merged 1 commit into from
Oct 23, 2019

Conversation

cceckman
Copy link
Contributor

Per discussion on the PR. This just copies the original proposal; it hasn't been revised per comments / discussions.

Those on the prior discussion:
/cc @mikedanese @liggitt @enj @micahhausler @ericchiang

@k8s-ci-robot
Copy link
Contributor

Welcome @cceckman!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @cceckman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2019
@mikedanese mikedanese added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 1, 2019
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels Aug 5, 2019
@mtaufen mtaufen mentioned this pull request Oct 23, 2019
Merged
@mtaufen
Copy link
Contributor

mtaufen commented Oct 23, 2019

I'm going to pick up work on this.

Does anything else need to be resolved before this KEP can be marked implementable and merged (presumably for 1.18, since I think we missed the 1.17 deadline)?

@mikedanese
Move kubernetes/community#2314 to a KEP.
084837d 
Per discussion on the PR. This just copies the original proposal; it
hasn't been revised per comments / discussions.
@mikedanese
Copy link
Member

We've covered this in a few recent sig-auth meetings and there aren't any outstanding objections or comments. I'll give this a grace period for any last comments, otherwise this looks ready to go.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cceckman, mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit cba7bf6 into kubernetes:master Oct 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 23, 2019
@mikedanese
Copy link
Member

I'm confused. I thought the lgtm didn't imply approve...

@mtaufen
Copy link
Contributor

mtaufen commented Oct 23, 2019 via email

@enj
Copy link
Member

enj commented Oct 24, 2019

I'm confused. I thought the lgtm didn't imply approve...

It is per repo configuration in prow IIRC.

@cceckman cceckman deleted the original-kep branch October 24, 2019 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese mikedanese left review comments

@mtaufen mtaufen mtaufen left review comments

@justinsb justinsb justinsb left review comments

@enj enj Awaiting requested review from enj

@ericchiang ericchiang Awaiting requested review from ericchiang

@liggitt liggitt Awaiting requested review from liggitt

@micahhausler micahhausler Awaiting requested review from micahhausler

Assignees

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
8 participants
@cceckman @k8s-ci-robot @mtaufen @mikedanese @enj @justinsb @micahhausler @liggitt