feat(scheduling): initialize kep for graduating schedule daemonset pods #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/scheduling
k8s-ci-robot
added
the
kind/kep
draveness
force-pushed
the
feature/graduate-schedule-daemonset-pods-to-ga
branch
3 times, most recently
from
14aebbd
to
853432b
Compare
k82cn
reviewed
Oct 12, 2019
keps/sig-scheduling/20191011-graduate-schedule-daemonset-pods-to-ga.md
Outdated
Show resolved
Hide resolved
k82cn
reviewed
Oct 12, 2019
keps/sig-scheduling/20191011-graduate-schedule-daemonset-pods-to-ga.md
Outdated
Show resolved
Hide resolved
|
LGTM overall :) |
k82cn
reviewed
Oct 12, 2019
keps/sig-scheduling/20191011-graduate-schedule-daemonset-pods-to-ga.md
Outdated
Show resolved
Hide resolved
k82cn
reviewed
Oct 12, 2019
|
|
||
| ### Risks and Mitigations | ||
|
|
||
| The major concern for graduating ScheduleDaemonSetPods to the stable version could be the overhead to the scheduler and the startup time of daemons. After we graduate this feature, the scheduler would select nodes for all of the DaemonSet pods, which may cause a lot of pods with NodeAffinity to be processed. |
There was a problem hiding this comment.
let's open an issue for performance concern to trace that, not a block issue.
There was a problem hiding this comment.
|
Hi @k82cn, do we need to create another issue for tracking the graduation or we could use the existing issue for this? |
draveness
force-pushed
the
feature/graduate-schedule-daemonset-pods-to-ga
branch
from
683b526
to
fc6ff1a
Compare
6 tasks
draveness
force-pushed
the
feature/graduate-schedule-daemonset-pods-to-ga
branch
from
fc6ff1a
to
31d8b74
Compare
|
cc/ @janetkuo |
draveness
force-pushed
the
feature/graduate-schedule-daemonset-pods-to-ga
branch
from
31d8b74
to
442d68f
Compare
draveness
force-pushed
the
feature/graduate-schedule-daemonset-pods-to-ga
branch
from
442d68f
to
6d36008
Compare
k8s-ci-robot
added
size/M
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: draveness, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @k82cn @ahg-g
/sig scheduling
/sig apps
ref: #548