Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "conformance without beta" KEP to implementable #1349

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Move "conformance without beta" KEP to implementable #1349

merged 2 commits into from
Nov 14, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 1, 2019 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2019
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Nov 1, 2019
@liggitt
Copy link
Member Author

liggitt commented Nov 1, 2019

/hold
for approvals

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2019
@liggitt liggitt requested review from deads2k and timothysc and removed request for derekwaynecarr November 1, 2019 15:50
@johnbelamaric
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 1, 2019
timothysc
timothysc approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@deads2k
Copy link
Contributor

deads2k commented Nov 1, 2019

I think that before moving to implementable, this KEP should add a phase 3 to its graduation criteria that involves identifying which APIs are actually required for conformance, restricting to that list and determining which optional GA libraries are being relied upon.

@liggitt liggitt mentioned this pull request Nov 14, 2019
Merged
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2019
@deads2k
Copy link
Contributor

deads2k commented Nov 14, 2019

Thanks.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, johnbelamaric, liggitt, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnbelamaric
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 970052b into kubernetes:master Nov 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Nov 14, 2019
@liggitt liggitt deleted the conformance-no-beta branch January 15, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@timothysc timothysc

@deads2k deads2k

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.
5 participants
@liggitt @johnbelamaric @deads2k @k8s-ci-robot @timothysc