Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2104: kube-proxy v2: reworking the proxy's architecture #2094

Closed
wants to merge 6 commits into from

Conversation

mcluseau
Copy link

Hi folks,

I started the process of writing the KEP for my proposal of a "kube-proxy v2", and I think I'm ready to get some early comments. Thanks in advance for kind reviews and ideas :-)

@thockin

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 10, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @mcluseau!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @mcluseau. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 10, 2020
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. labels Oct 10, 2020
@mcluseau mcluseau changed the title [DO-NOT-MERGE] [WIP] 20201010-kube-proxy-v2: initial commit [DO-NOT-MERGE] [WIP] 20201010 kube-proxy v2: reworking the proxy's architecture Oct 10, 2020
Copy link
Contributor

@danwinship danwinship left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I like it.

keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
Copy link
Author

@mcluseau mcluseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this first review, it's really nice to have external viewpoints :)

keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
This KEP is born from the conviction that more decoupling of the Service object and the actual implementations is required,
by introducing an intermediate, node-level abstaction provider. This abstraction is expected to be the result of applying
Kubernetes' `Service` semantics and business logic to a simpler, more stable API.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good example of the interest of the decoupling I'm trying to achieve. Same idea with adding the topology concept.

keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
keps/sig-network/20201010-kube-proxy-v2/README.md Outdated Show resolved Hide resolved
@robscott
Copy link
Member

robscott commented Nov 4, 2020

/cc

@thockin thockin self-assigned this Nov 22, 2020
@thockin
Copy link
Member

thockin commented Dec 9, 2020 via email

@mattklein123
Copy link

That should work for me also. Let me know the invite details.

@htuch
Copy link

htuch commented Dec 9, 2020

Works for me.

@mcluseau
Copy link
Author

mcluseau commented Dec 9, 2020

yes, it's next monday, I'll post the link. I'll use meet unless there's a strong preference for zoom.

@howardjohn
Copy link

@mcluseau is this still on for today? Is there any info on the meeting address?

@mcluseau
Copy link
Author

@howardjohn yes it's still today, I'll post the link here in 3h (30 min before the meeting)

@mcluseau
Copy link
Author

hi all, meeting link: meet.google.com/jjf-szrn-qre

@jayunit100
Copy link
Member

Were going to break this KEP into 3 sections , per conv w others today in sig-network

  • GRPC API
  • Process for migrating into /staging
  • Performance, Scale, and Conformance testing

Then we'll resubmit to Sig-network

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 11, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knabben
Copy link
Member

knabben commented Apr 4, 2023

/reopen
/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot reopened this Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

@knabben: Reopened this PR.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 4, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mcluseau
Once this PR has been reviewed and has the lgtm label, please ask for approval from thockin. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2023
@liangyuanpeng
Copy link

/lifecycle frozen

@k8s-ci-robot
Copy link
Contributor

@liangyuanpeng: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to this:

/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 19, 2024
@thockin
Copy link
Member

thockin commented Jan 29, 2024

Time to close this now? I think the nftables KEP supersedes.

@thockin thockin closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Development

Successfully merging this pull request may close these issues.

None yet