Tweak kubeadm release notes #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Beda <joe.github@bedafamily.com>
k8s-ci-robot
added
the
cncf-cla: yes
|
I didn't list every changed command-line flag as I think it would create more noise than be helpful. |
|
Also /cc @luxas @pires @errordeveloper |
mikedanese
reviewed
Mar 22, 2017
| external etcd settings and the option for setting the cloud provider on the | ||
| API server. The [kubeadm reference | ||
| documentation](https://kubernetes.io/docs/admin/kubeadm/) is up to date with | ||
| the new flags. | ||
| - A new label and taint is used for marking the master. The label is | ||
| `node-role.kubernetes.io/master=""` and the taint has the effect |
There was a problem hiding this comment.
We should remove and the taint has the effect NoSchedule, it doesn't make sense in this sentence.
|
[redact comment, can't read good] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some more detail and references.
This is a continuation of #211.
Astute readers will notice that I accidentally checked this in directly and then reverted it. Sorry about that.