Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated KEP to new format - sig-api-machinery #2331

Closed
wants to merge 1 commit into from
Closed

Migrated KEP to new format - sig-api-machinery #2331

wants to merge 1 commit into from

Conversation

shekhar-rajak
Copy link
Contributor

Related to: #2220

Migrating the old KEP files into new format - sig-api-machinery

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 26, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @shekhar-rajak. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2021
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jan 26, 2021
This was referenced Jan 26, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Open
Closed
Closed
Closed
@shekhar-rajak shekhar-rajak force-pushed the kep_new_template_sig_api_machinery branch from 337fdd9 to 053528e Compare January 26, 2021 11:42
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 26, 2021
@shekhar-rajak shekhar-rajak changed the title [WIP] Migrated KEP to new format - sig-api-machinery Migrated KEP to new format - sig-api-machinery Jan 26, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2021
@shekhar-rajak
Copy link
Contributor Author

This PR is ready for review.

@wojtek-t
Copy link
Member

/ok-to-test

/assign @deads2k @lavalamp

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2021
@shekhar-rajak
Migrating from old kep to new template - kep-number: 2330
ea9ac2a 
all the sig-api-machinery keps migrated to new template

renaming the directory name
@shekhar-rajak shekhar-rajak force-pushed the kep_new_template_sig_api_machinery branch from 053528e to ea9ac2a Compare January 27, 2021 16:56
@shekhar-rajak
Copy link
Contributor Author

I have fix the test case failure: Directory/spelling error. Please add "ok-to-test" label.

@shekhar-rajak
Copy link
Contributor Author

I believe this PR is good to go :)

@deads2k
Copy link
Contributor

deads2k commented Feb 8, 2021

I believe this PR is good to go :)

thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, shekhar-rajak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2021
@deads2k deads2k mentioned this pull request Feb 8, 2021
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2021
@k8s-ci-robot
Copy link
Contributor

@shekhar-rajak: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

2 similar comments
@k8s-ci-robot
Copy link
Contributor

@shekhar-rajak: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@shekhar-rajak: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wojtek-t
Copy link
Member

wojtek-t commented Feb 9, 2021

Closing in favor of #2460

/close

@k8s-ci-robot
Copy link
Contributor

@wojtek-t: Closed this PR.

In response to this:

Closing in favor of #2460

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedebongio fedebongio Awaiting requested review from fedebongio

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@lavalamp lavalamp

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shekhar-rajak @k8s-ci-robot @wojtek-t @deads2k @lavalamp