Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing KEPs 2004 and 2030 as they were never implemented #2666

Merged
merged 1 commit into from
May 4, 2021

Conversation

robscott
Copy link
Member

@robscott robscott commented Apr 30, 2021

These KEPs were effectively replaced by KEP #2433. Since they never even reached alpha, I don't think there's much of a need to leave them in here.

Fixes #2004
Fixes #2030

/sig network
/assign @thockin

These KEPs were effectively replaced by KEP 2433. Since they never even
reached alpha, I don't think there's much of a need to leave them in
here.
@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Apr 30, 2021
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 30, 2021
@robscott
Copy link
Member Author

For the record, I'm also fine with leaving these KEPs in and updating them to status "replaced". I took the removal approach here because I think it would be confusing to have 4 networking KEPs with "topology" in the name, but not sure what the standard is for removal.

/cc @johnbelamaric

@aojea
Copy link
Member

aojea commented May 2, 2021

For the record, I'm also fine with leaving these KEPs in and updating them to status "replaced".

indeed it can be good to have them for historical context

@thockin
Copy link
Member

thockin commented May 4, 2021

I lean towards removal - they are in the permanent history if we need to get them back.

Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2ec2282 into kubernetes:master May 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topology Aware Proxying Topology Aware Subsetting
4 participants