KEP-2901: remove scheduler policy and cc v1beta1 #2921
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
kind/kep
kerthcet
changed the title
kerthcet
force-pushed
the
feature/remove-scheduler-policy-config
branch
2 times, most recently
from
09aaab2
to
f43bddb
Compare
keps/sig-scheduling/785-scheduler-component-config-api/README.md
Outdated
Show resolved
Hide resolved
| - 2021-07-08: Introducing `v1beta2`. | ||
| - 2021-08-06: Introducing `v1beta3`. |
There was a problem hiding this comment.
add one more line:
- 2021-09-01: remove
v1beta1and the legacy policy config API.
There was a problem hiding this comment.
correct me if not, i thought we only plan to remind users about the v1beta1 deprecated policy, such as adding a warning log, or we want to remove the source code？
There was a problem hiding this comment.
this is just a log of updates to this kep
There was a problem hiding this comment.
I think we can safely remove v1beta1 based on when it was introduced (1.19), but v1beta2 has only existed as a replacement for 1 release, is that enough time for deprecation?
There was a problem hiding this comment.
@ahg-g I think the question is in the wording for the log... 2021-09-21: remove v1beta1... vs 2021-09-21: mark v1beta1 deprecated
There was a problem hiding this comment.
privide some messages, maybe not conformable. as deprecation policy says, Beta feature to EOL: 3 months or 1 release (whichever is longer), we introduced v1beta1 in release 1.19, more than 3 months or one release.
There was a problem hiding this comment.
I think we want to remove it completely. We can do so and it is likely better to reduce clutter and the overhead of maintaining three beta versions.
There was a problem hiding this comment.
updated both places, section under introducing v1beta3 and implementation history.
There was a problem hiding this comment.
+1 to remove v1beta1 when v1beta3 gets introduced. It's not that typical/necessary to keep 3+ APIs at the same time.
kerthcet
force-pushed
the
feature/remove-scheduler-policy-config
branch
from
f43bddb
to
89fbeab
Compare
kerthcet
changed the title
| - 2021-07-08: Introducing `v1beta2`. | ||
| - 2021-08-06: Introducing `v1beta3`. |
There was a problem hiding this comment.
+1 to remove v1beta1 when v1beta3 gets introduced. It's not that typical/necessary to keep 3+ APIs at the same time.
Signed-off-by: kerthcet <kerthcet@gmail.com>
kerthcet
force-pushed
the
feature/remove-scheduler-policy-config
branch
from
89fbeab
to
c000ab4
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kerthcet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I'll help to remove all these codes. |
Signed-off-by: kerthcet kerthcet@gmail.com
Implementation Historyupdate of kep Introduce v1beta3 API for scheduler ComponentConfig #2850