Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-1753: Deprecate dynamic log sanitization #3096

Merged
merged 3 commits into from
Jan 7, 2022
Merged

KEP-1753: Deprecate dynamic log sanitization #3096

merged 3 commits into from
Jan 7, 2022

Conversation

ehashman
Copy link
Member

  • One-line PR description: Deprecate dynamic log sanitization

@ehashman
Rehome KEP-1753 for deprecation
a355197 
SIG Instrumentation is leading the deprecation of this feature as
we own some of the code. We started it, we'll finish it :)
@ehashman
Update KEP-1753 metadata for deprecation
a0b1755
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 23, 2021
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 23, 2021
@ehashman ehashman mentioned this pull request Dec 23, 2021
Merged
@ehashman
Copy link
Member Author

/hold

awaiting sufficient feedback, preventing accidental merges

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 23, 2021
@tabbysable
Copy link
Member

/lgtm
/approve
/meow

Not removing the hold just now

@k8s-ci-robot
Copy link
Contributor

@tabbysable: cat image

In response to this:

/lgtm
/approve
/meow

Not removing the hold just now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ehashman, tabbysable

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tabbysable
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 27, 2021
@PurelyApplied
Copy link
Contributor

PurelyApplied commented Dec 28, 2021 •
edited

This KEP overlapped with KEP-1933's static analysis a bit, notably that the analysis is intended to be based on the struct tags proposed as part of this KEP.  In the last SIG-Security meeting, we discussed splitting the stuct-tags portion into its own KEP in the near future.

I don't know that there's anything actionable on that info (other than writing the new KEP), just FYI. (Also mentioned in the PR.)

@tabbysable
Copy link
Member

@PurelyApplied It's a good idea to update KEP 1933 to import responsibility for the struct tags. Feel free to just do it yourself, or come to SIG Security (slack or meeting) and ask for assistance.

@ehashman
Copy link
Member Author

ehashman commented Jan 5, 2022

@PurelyApplied Since the static analysis needs the data policy tags I have left them in. Let me update the KEP to state this expectation explicitly as part of the deprecation plan.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2022
@ehashman
Copy link
Member Author

ehashman commented Jan 5, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2022
@PurelyApplied
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 875dc3f into kubernetes:master Jan 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 7, 2022
@PurelyApplied PurelyApplied mentioned this pull request Jan 7, 2022
Merged
rikatz pushed a commit to rikatz/enhancements that referenced this pull request Feb 1, 2022
@ehashman @rikatz
KEP-1753: Deprecate dynamic log sanitization (kubernetes#3096)
f65e9de 
* Rehome KEP-1753 for deprecation

SIG Instrumentation is leading the deprecation of this feature as
we own some of the code. We started it, we'll finish it :)

* Update KEP-1753 metadata for deprecation

* Update KEP-1753 with deprecation notice
@palnabarun palnabarun mentioned this pull request Jun 12, 2022
Closed
@palnabarun palnabarun mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz Awaiting requested review from brancz

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@PurelyApplied PurelyApplied

@tabbysable tabbysable

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ehashman @tabbysable @k8s-ci-robot @PurelyApplied