Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3570: graduate kubelet cpumanager to GA #3350

Merged
merged 7 commits into from
Oct 5, 2022
Merged

KEP-3570: graduate kubelet cpumanager to GA #3350

merged 7 commits into from
Oct 5, 2022

Conversation

ffromani
Copy link
Contributor

@ffromani ffromani commented Jun 7, 2022 •
edited
Loading

  • Graduate kubelet CPUManager to GA
  • Other comments:
    The PR is organized as follows:
  1. the first commit is a translation as more mechanical as possible from the ancient document format to the newest available at moment of writing. Care is taken to alter as little as possible the original content, with the only purpose to make it fit in the new format
  2. the second commit adds all the new information not required when the original document was written, mostly concern with the PRR reviews.
  3. the third commit start updating the content with the plans to GA in 1.26
  4. the fourth (and following, if needed) commit adds the new content required by the new format, questionnaires.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 7, 2022
@ffromani ffromani marked this pull request as draft June 7, 2022 15:56
@k8s-ci-robot k8s-ci-robot requested a review from dchen1107 June 7, 2022 15:56
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 7, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 5, 2022
@ffromani
Copy link
Contributor Author

ffromani commented Sep 6, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 6, 2022
@ffromani
Copy link
Contributor Author

trivial rebase

@ffromani
node: cpumgr: port to the latest KEP template
fcf3a5a 
This change wants to do as much as mechanical translation
as possible; as consequence, we have now many gaps and TODOs,
which will be filled in followup PR.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
node: cpumgr: add missing PRR info
315b397 
This KEP originally predate PRRs.
We will have a PRR for the graduation to stable, and we
retrofill the infos for alpha and beta graduations.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani
node: cpumgr: move to stable in 1.26
ee7f329 
Add the missing metadata to promote to stable in 1.26

Signed-off-by: Francesco Romani <fromani@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2022
@ffromani ffromani marked this pull request as ready for review September 29, 2022 15:37
@ffromani
Copy link
Contributor Author

some pending TBDs/TODOs, hence the WIP, but the PR is now un-drafted.

@ffromani
node: cpumgr: address the pending questions
9ed4fd2 
Address the questionnaire required for GA graduation.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 30, 2022
@ffromani
node: cpumgr: address review comments
b57f64b 
Formatting fixes, clarifications (feature gate, options)

Signed-off-by: Francesco Romani <fromani@redhat.com>
@ffromani ffromani force-pushed the cpumanager-ga branch 2 times, most recently from ba82a83 to 573a966 Compare October 5, 2022 16:10
swatisehgal
swatisehgal reviewed Oct 5, 2022
View reviewed changes
Copy link
Contributor

@swatisehgal swatisehgal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a couple of minor comments.

keps/sig-node/3570-cpumanager/README.md Outdated Show resolved Hide resolved
keps/sig-node/3570-cpumanager/README.md Show resolved Hide resolved
@ffromani
node: cpumgr: add metrics information
e1d1af1 
During the review of the KEP, it emerged there are possible
metrics we should add, tracking admission and errors.
CPU allocation is done at admission time, and extracting
these metrics is expected to be both cheap and useful for monitoring.

Signed-off-by: Francesco Romani <fromani@redhat.com>
@deads2k
Copy link
Contributor

deads2k commented Oct 5, 2022

PRR looks good. Thank you for the updates.

/approve

@swatisehgal
Copy link
Contributor

Thanks for promptly addressing all the review comments.

/lgtm
from node-perspective (non-binding)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2022
@swatisehgal
Copy link
Contributor

/cc @derekwaynecarr @dchen1107 @mrunalp @klueska
for sig-node approval

@mrunalp
Copy link
Contributor

mrunalp commented Oct 5, 2022

/approve

@mrunalp
Copy link
Contributor

mrunalp commented Oct 5, 2022

/assign @dchen1107

@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, deads2k, fromanirh, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 07be964 into kubernetes:master Oct 5, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 5, 2022
@ffromani ffromani deleted the cpumanager-ga branch November 10, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swatisehgal swatisehgal swatisehgal left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@deads2k deads2k deads2k left review comments

@dchen1107 dchen1107 dchen1107 left review comments

@MarSik MarSik MarSik left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@klueska klueska Awaiting requested review from klueska

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@dchen1107 dchen1107

@swatisehgal swatisehgal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
10 participants
@ffromani @k8s-triage-robot @derekwaynecarr @deads2k @swatisehgal @mrunalp @dchen1107 @k8s-ci-robot @MarSik @andrewsykim