KEP-3488: Resolve outstanding issue: handling of enforcement #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
kind/kep
k8s-ci-robot
removed
the
approved
jpbetz
force-pushed
the
enforcement
branch
3 times, most recently
from
074be4c
to
c594d24
Compare
k8s-ci-robot
added
the
approved
jpbetz
changed the title
lavalamp
reviewed
Oct 3, 2022
lavalamp
reviewed
Oct 3, 2022
lavalamp
reviewed
Oct 3, 2022
lavalamp
reviewed
Oct 3, 2022
lavalamp
reviewed
Oct 3, 2022
Co-authored-by: Daniel Smith <dbsmith@google.com>
|
Thanks @lavalamp! Feedback applied. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers: The "Decisions and Enforcement" section summaries the core change proposed.
Issue link: CEL for Admission Control #3488
Other comments: We only have 5 weeks to implement this so we're keeping phase 1 to a minimum. We will do more design work for phase 2, but believe we have enough information to implement phase 1 without painting ourselves into a corner.