Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-2876: Clear Graduation Criteria for CRD validation rules to stable #3948

Merged
merged 2 commits into from
May 10, 2023
Merged

KEP-2876: Clear Graduation Criteria for CRD validation rules to stable #3948

merged 2 commits into from
May 10, 2023

Conversation

cici37
Copy link
Contributor

@cici37 cici37 commented Apr 10, 2023

  • One-line PR description: Promote CRD validation rules to stable
  • Other comments:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 10, 2023
@cici37 cici37 marked this pull request as ready for review April 10, 2023 08:37
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2023
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Apr 10, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2023
@cici37 cici37 mentioned this pull request Apr 10, 2023
Closed
21 tasks
@cici37 cici37 changed the title KEP-2876: Promote CRD validation rules to stable KEP-2876: Clear Graduation Criteria for CRD validation rules to stable Apr 27, 2023
@cici37
Copy link
Contributor Author

cici37 commented Apr 27, 2023

/milestone v1.28
Updated the PR based on today's discussion. Please feel free to have a look when have time. Thank you!
@jpbetz @liggitt

@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 27, 2023
@liggitt
Copy link
Member

liggitt commented May 10, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2023
@jpbetz
Copy link
Contributor

jpbetz commented May 10, 2023

/approve
This has all the outstanding items I'm aware of.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cici37, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit f0a7c50 into kubernetes:master May 10, 2023
@cici37 cici37 deleted the crdGA branch May 10, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz jpbetz left review comments

@liggitt liggitt liggitt left review comments

@deads2k deads2k Awaiting requested review from deads2k

@fedebongio fedebongio Awaiting requested review from fedebongio

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
4 participants
@cici37 @k8s-ci-robot @liggitt @jpbetz