Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate testgrid dashboard URL from k8s-testgrid.appspot.com to testgrid.k8s.io #4154

Merged
merged 1 commit into from
Nov 14, 2023
Merged

migrate testgrid dashboard URL from k8s-testgrid.appspot.com to testgrid.k8s.io #4154

merged 1 commit into from
Nov 14, 2023

Conversation

Ritikaa96
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Which issue(s) this PR fixes:
Fix links to the test grid dashboard

Related Umbrella Issue kubernetes/test-infra#30370

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Aug 17, 2023
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. labels Aug 17, 2023
@letmerecall letmerecall mentioned this pull request Aug 17, 2023
Closed
40 tasks
@bart0sh
Copy link
Contributor

bart0sh commented Aug 21, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@jsturtevant
Copy link
Contributor

/lgtm
/approve
for sig-windows changes

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2023
@Ritikaa96 Ritikaa96 force-pushed the migrate-testgrid-link branch from ac04e22 to da3ee16 Compare September 5, 2023 06:38
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 5, 2023
@Ritikaa96
Copy link
Contributor Author

/lgtm /approve for sig-windows changes

Hi @jsturtevant , just rebased it . Please take a look

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2023
@Ritikaa96
migrate testgrid dashboard URL from k8s-testgrid.appspot.com to testg…
7e841ee 
…rid.k8s.io

Signed-off-by: Ritikaa96 <ritika@india.nec.com>
@Ritikaa96 Ritikaa96 force-pushed the migrate-testgrid-link branch from da3ee16 to 7e841ee Compare October 18, 2023 12:11
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 18, 2023
@Ritikaa96
Copy link
Contributor Author

Easy CLA is signed already, i will try to retest or send another commit to add the cncf label

@Ritikaa96
Copy link
Contributor Author

Ritikaa96 commented Oct 25, 2023 •
edited
Loading

can someone let me know the command to rerun this check in the GitHub thread? or making another commit is the only option?
As i don't have anything else to edit in this PR, it will be redundant to add another commit just for test.

@letmerecall
Copy link

@Ritikaa96 , are you looking for /retest ?

https://www.kubernetes.dev/docs/contributor-cheatsheet/#troubleshooting-a-pull-request

@Ritikaa96
Copy link
Contributor Author

Ritikaa96 commented Oct 30, 2023 •
edited
Loading

Maybe yes @letmerecall thank you !

@Ritikaa96
Copy link
Contributor Author

/retest

@Ritikaa96
Copy link
Contributor Author

I don't think retest is the one. the tests aren't rerun after the command.

@letmerecall
Copy link

@Ritikaa96, can you try commenting /easycla?

reference: https://confluence.linuxfoundation.org/display/LP/LFX+EasyCLA

@letmerecall
Copy link

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 5, 2023
@letmerecall
Copy link

@jsturtevant PTAL

@letmerecall
Copy link

cc: @dims
Could you help approve this one please?

@Ritikaa96
Copy link
Contributor Author

/easycla

thanks @letmerecall

@Ritikaa96
Copy link
Contributor Author

/remove-kind kep

@k8s-ci-robot k8s-ci-robot removed the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Nov 14, 2023
@dims
Copy link
Member

dims commented Nov 14, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jsturtevant, Ritikaa96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9614f0e into kubernetes:master Nov 14, 2023
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 14, 2023
@Ritikaa96
Copy link
Contributor Author

Thanks @dims @letmerecall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgetkromhout bridgetkromhout Awaiting requested review from bridgetkromhout

@dashpole dashpole Awaiting requested review from dashpole

Assignees

@dims dims

@jsturtevant jsturtevant

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Auth
Archived in project
SIG Node: code and documentation PRs
Archived in project
SIG Scheduling
Archived in project
[sig-windows] PR tracking
Status: Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@Ritikaa96 @bart0sh @jsturtevant @letmerecall @dims @k8s-ci-robot