-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-4261: Add support for multiple metrics APIs #4262
Conversation
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JorTurFer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @JorTurFer! |
Hi @JorTurFer. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Thank you for opening this @JorTurFer we need this functionality as well. |
|
||
Before choosing the option of modifying the HPA, we evaluated the idea of creating a totally new component that users can install in their clusters as a proxy, to achieve this goal based on configurations and/or namespaces. After some considerations and initial designs, we discarded it due to some reasons: | ||
It’d require a 3rd party installed within the cluster, generating user rejection from users. | ||
It’s another single point of failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s another single point of failure. |
Kubernetes lets you run replicated services for improved availability. I don't think this is a true drawback.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@chicks-net: You can't reopen an issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/reopen |
@afirth: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this improvement needs: willing volunteers that have the capacity. So
far, we didn't find some.
Personally I'd prefer to see an out-of-tree component that lets you
aggregate metric sources, rather than the approach in this KEP. But either
way, it's volunteer time and effort that is needed to manage the work
around improving Kubernetes.
.
|
We finally decided to go using an external proxy rather than modifying the k8s API. I've created a PoC that verifies to idea to check if it's feasible or not (it is), but I haven't had enough time to finish and publish the project. I hope that it'll be ready during next months |
Thanks @JorTurFer, also for your help in the past when I had to deal with this! Do you have a link to the PoC that people could potentially explore or contribute to? |
Add support for multiple metrics APIs, allowing multiple services exposing metrics on same metric type
Support for multiple metrics APIs #4261