Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4261: Add support for multiple metrics APIs #4262

Closed
wants to merge 3 commits into from
Closed

KEP-4261: Add support for multiple metrics APIs #4262

wants to merge 3 commits into from

Conversation

JorTurFer
Copy link

@JorTurFer JorTurFer commented Oct 2, 2023 •
edited

  • One-line PR description:
    Add support for multiple metrics APIs, allowing multiple services exposing metrics on same metric type

@JorTurFer
KEP-4261: Add support for multiple metrics APIs
11486bb 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JorTurFer
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @JorTurFer!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @JorTurFer. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Oct 2, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 2, 2023
@dgrisonnet dgrisonnet mentioned this pull request Oct 2, 2023
Closed
4 tasks
@JorTurFer
update title
23dbbb8 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer mentioned this pull request Oct 21, 2023
Open
@vsoch
Copy link

vsoch commented Oct 21, 2023

Thank you for opening this @JorTurFer we need this functionality as well.

@vsoch vsoch mentioned this pull request Nov 2, 2023
Closed
3 tasks
@JorTurFer JorTurFer mentioned this pull request Dec 11, 2023
Open
sftim
sftim reviewed Jan 4, 2024
View reviewed changes
keps/sig-autoscaling/4261-multiple-metrics-apis/README.md

Before choosing the option of modifying the HPA, we evaluated the idea of creating a totally new component that users can install in their clusters as a proxy, to achieve this goal based on configurations and/or namespaces. After some considerations and initial designs, we discarded it due to some reasons:
It’d require a 3rd party installed within the cluster, generating user rejection from users.
It’s another single point of failure.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It’s another single point of failure.

Kubernetes lets you run replicated services for improved availability. I don't think this is a true drawback.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 3, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 3, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@chicks-net
Copy link

/reopen

@k8s-ci-robot
Copy link
Contributor

@chicks-net: You can't reopen an issue/PR unless you authored it or you are a collaborator.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@afirth
Copy link
Member

afirth commented Jul 23, 2024

/reopen
I don't understand how this gets so little attention. If you run a pre-keda cluster and want to switch, you're going to hit this and end up doing some janky nginx --insecure stuff. It seems like core functionality (HPA) that is now tied to keda implementing everything anyone needs. Let me know if there's anything I can do to help this forward

@k8s-ci-robot k8s-ci-robot reopened this Jul 23, 2024
@k8s-ci-robot
Copy link
Contributor

@afirth: Reopened this PR.

In response to this:

/reopen
I don't understand how this gets so little attention. If you run a pre-keda cluster and want to switch, you're going to hit this and end up doing some janky nginx --insecure stuff. It seems like core functionality (HPA) that is now tied to keda implementing everything anyone needs. Let me know if there's anything I can do to help this forward

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sftim
Copy link
Contributor

sftim commented Jul 23, 2024 via email

@JorTurFer
Copy link
Author

We finally decided to go using an external proxy rather than modifying the k8s API. I've created a PoC that verifies to idea to check if it's feasible or not (it is), but I haven't had enough time to finish and publish the project. I hope that it'll be ready during next months

@JorTurFer JorTurFer closed this Jul 24, 2024
@afirth
Copy link
Member

afirth commented Jul 24, 2024

Thanks @JorTurFer, also for your help in the past when I had to deal with this! Do you have a link to the PoC that people could potentially explore or contribute to?
(I came here from kubernetes-sigs/custom-metrics-apiserver#70)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JorTurFer @k8s-ci-robot @vsoch @k8s-triage-robot @chicks-net @afirth @sftim