keps/../kubeadm: 4214: revisit test plan and risks/mitigations #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
kind/kep
Update notes about Risk and Mitigations: - As a mistaken existing implementation detail "admin.conf" is not shared across control plane nodes, by using the "kubeadm-certs" Secret. Instead on "kubeadm join --control-plane" a new "admin.conf" is signed by using the shared in "kubeadm-certs" CA. - Re-place upgrade clusters must apply the "kubeadm:cluster-admins" ClusterRoleBinding if they wish the "admin.conf" files on joining control plane nodes to have "cluster-admin" level access. Update Test Plane: - Don't add integration tests, instead add an e2e test using kinder that will do kubeadm init/join/upgrade and verify certificates stored in kubeconfig files nad RBAC.
neolit123
force-pushed
the
1.29-add-kep-for-separate-kubeconfig-system-masters
branch
from
6a0315d
to
95f1f4d
Compare
i pinged the #cluster-api slack about this: |
neolit123
requested review from
pacoxu,
chendave and
SataQiu
and removed request for
justinsb and
fabriziopandini
SataQiu
reviewed
Oct 19, 2023
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
14 tasks
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update notes about Risk and Mitigations:
Update Test Plan:
Don't add integration tests, instead add an e2e test using kinder that will do kubeadm init/join/upgrade and verify certificates stored in kubeconfig files nad RBAC.
Issue link:
kubeadm: generate a client certificate with "system:masters" in a separate file #4214