Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add known failure mode for Server Side Apply #4308

Closed
wants to merge 2 commits into from
Closed

Add known failure mode for Server Side Apply #4308

wants to merge 2 commits into from

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Oct 20, 2023

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mimowo
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 20, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Oct 20, 2023

/assign @liggitt
FYI @apelisse @alculquicondor

@mimowo mimowo mentioned this pull request Oct 20, 2023
Closed
@mimowo mimowo force-pushed the ssa-known-failure-mode branch 3 times, most recently from 7f92989 to 81786ee Compare October 20, 2023 11:35
liggitt
liggitt reviewed Oct 20, 2023
View reviewed changes
keps/sig-api-machinery/555-server-side-apply/README.md
container pods are not created. Also, update the existing pods to cleanup
the problematic fields.
- Testing: [PodGC integration test](https://github.com/kubernetes/kubernetes/blob/7b9d244efd19f0d4cce4f46d1f34a6c7cff97b18/test/integration/podgc/podgc_test.go#L313)
reproduced the issue before withdrawing from SSA in PodGC in the [PR #121103](https://github.com/kubernetes/kubernetes/pull/121103).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix for this is in flight in kubernetes-sigs/structured-merge-diff#253, I don't think updating the design doc for this is helpful... the github issues mentioned seem sufficient, especially once the SSA impact is fixed

Copy link
Contributor Author

@mimowo mimowo Oct 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware of the ongoing fix.

Still, it might be worth it to inform users, who might be using older versions somehow, and the section "known failure modes" seems the valid place. However, if there is consensus this is not the right place, then I'm happy to close the PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the "known failure modes" are about failure modes inherent in the design, but will defer to @apelisse if he thinks it's useful to include this here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this more of a decision of a PRR reviewer. What's your stance @wojtek-t?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be useful to include it here, but since the fix is very close to land, I would wait to see how we manage to backport it and stuff before updating since we will have to update again soon anyways.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally merge it, but requires SIG lead approval.

@soltysh - can you please approve?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally merge it, but requires SIG lead approval.

@soltysh - can you please approve?

This one falls under api-machinery so @deads2k, @jpbetz or @fedebongio

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chasing the structured-merge-diff failure, it appears to have merged into kube in kubernetes/kubernetes#121575. Is this "SSA doesn't work under these conditions" still valid?

Copy link
Contributor Author

@mimowo mimowo Feb 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC the generic issue remains open: kubernetes/kubernetes#113482
However, the kubernetes/kubernetes#121575 PR fixes the use-case we had for pod disruption conditions, where subresource is patched. So using SSA for status is fixed, but not in general.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have queued at item in the apimachinery agenda for "sometime after kep freeze": https://docs.google.com/document/d/1x9RNaaysyO0gXHIr1y50QFbiL1x8OWnk2v3XnrdkT5Y/edit

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@wojtek-t
Copy link
Member

wojtek-t commented Feb 7, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2024
@soltysh
Copy link
Contributor

soltysh commented Feb 7, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Feb 7, 2024
@mimowo mimowo closed this Feb 10, 2024
@mimowo mimowo deleted the ssa-known-failure-mode branch February 10, 2024 11:49
@mimowo mimowo restored the ssa-known-failure-mode branch February 10, 2024 11:50
@mimowo
Copy link
Contributor Author

mimowo commented Feb 10, 2024 •
edited
Loading

/reopen
Closed by mistake during my local cleanup

@k8s-ci-robot
Copy link
Contributor

@mimowo: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Feb 10, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 11, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh left review comments

@liggitt liggitt liggitt left review comments

@alculquicondor alculquicondor alculquicondor left review comments

@apelisse apelisse apelisse left review comments

@deads2k deads2k deads2k left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@fedebongio fedebongio Awaiting requested review from fedebongio

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@liggitt liggitt

@wojtek-t wojtek-t

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mimowo @k8s-ci-robot @k8s-triage-robot @wojtek-t @soltysh @liggitt @alculquicondor @apelisse @deads2k