Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP: Custom Resource Field Selectors #4359

Merged
merged 1 commit into from
Jan 18, 2024
Merged

KEP: Custom Resource Field Selectors #4359

merged 1 commit into from
Jan 18, 2024

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Dec 12, 2023 •
edited
Loading

  • One-line PR description: Add field selector support to CustomResourceDefinitions.
  • Other comments:

Implementation: kubernetes/kubernetes#122717

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2023
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 12, 2023
@jpbetz jpbetz mentioned this pull request Dec 12, 2023
Open
15 tasks
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 14, 2023
@jpbetz jpbetz force-pushed the crd-object-selectors branch 3 times, most recently from 8d013cc to 7142484 Compare December 15, 2023 05:54
@jpbetz jpbetz marked this pull request as ready for review January 9, 2024 06:49
@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 11, 2024
@jpbetz jpbetz force-pushed the crd-object-selectors branch 2 times, most recently from afce6cb to 7c3f593 Compare January 11, 2024 23:09
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2024
@jpbetz jpbetz mentioned this pull request Jan 12, 2024
Merged
deads2k
deads2k reviewed Jan 12, 2024
View reviewed changes
keps/sig-api-machinery/4358-custom-resource-field-selectors/README.md Outdated
"org.example.v1.CustomResource": {
"type": "object",
"x-kubernetes-group-version-kind": [ ... ],
"x-kubernetes-selectable-fields": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jefftree and @sttts for openapi extension details.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on openapi extension naming, added one question comment

@deads2k
Copy link
Contributor

deads2k commented Jan 12, 2024

the KEP lgtm, but needs comments on the openapi changes from someone with more familiarity. I've suggested Jeffrey and Stefan.

@alvaroaleman alvaroaleman mentioned this pull request Jan 12, 2024
Open
@CatherineF-dev
Copy link
Contributor

Hi, could it support .spec.*.color?

context: kube-state-metrics collects custom resource metrics. Some users use .spec.*.color to select some custom resource fields. Related: kubernetes/kube-state-metrics#1978

Jefftree
Jefftree reviewed Jan 16, 2024
View reviewed changes
keps/sig-api-machinery/4358-custom-resource-field-selectors/README.md Outdated Show resolved Hide resolved
keps/sig-api-machinery/4358-custom-resource-field-selectors/README.md Outdated Show resolved Hide resolved
keps/sig-api-machinery/4358-custom-resource-field-selectors/README.md Outdated Show resolved Hide resolved
keps/sig-api-machinery/4358-custom-resource-field-selectors/README.md Show resolved Hide resolved
keps/sig-api-machinery/4358-custom-resource-field-selectors/README.md Outdated
"org.example.v1.CustomResource": {
"type": "object",
"x-kubernetes-group-version-kind": [ ... ],
"x-kubernetes-selectable-fields": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on openapi extension naming, added one question comment

@deads2k
Copy link
Contributor

deads2k commented Jan 18, 2024

discussion looks resolved. Design and PRR both lgtm

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, jpbetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 01efead into kubernetes:master Jan 18, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Jan 18, 2024
@jpbetz jpbetz mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@sbueringer sbueringer sbueringer left review comments

@Jefftree Jefftree Jefftree left review comments

@deads2k deads2k deads2k left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@fedebongio fedebongio Awaiting requested review from fedebongio

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
8 participants
@jpbetz @k8s-ci-robot @deads2k @CatherineF-dev @liggitt @sbueringer @Jefftree @wojtek-t