Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP 3521/3838: graduate PodSchedulingReadiness to stable #4455

Merged
merged 2 commits into from
Feb 1, 2024
Merged

KEP 3521/3838: graduate PodSchedulingReadiness to stable #4455

merged 2 commits into from
Feb 1, 2024

Conversation

Huang-Wei
Copy link
Member

@Huang-Wei Huang-Wei commented Jan 29, 2024 •
edited
Loading

  • One-line PR description: graduate PodSchedulingReadiness to stable
  • Other comments: This PR graduates two KEPs (3521 and 3838) to stable as they're both controlled by the same feature gate PodSchedulingReadiness

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2024
Huang-Wei
Huang-Wei commented Jan 29, 2024
View reviewed changes
keps/prod-readiness/sig-scheduling/3521.yaml
@@ -3,3 +3,5 @@ alpha:
approver: "@wojtek-t"
beta:
approver: "@wojtek-t"
stable:
approver: "@wojtek-t"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wojtek-t feel free to delegate to other PRR approver 🙏

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do that - can you please have SIG-level approacl too (in addition to your implicit one)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Huang-Wei can you please update https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/3838-pod-mutable-scheduling-directives in the same PR? both use the same feature gate flag, and so practically are graduating together.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahg-g Done. @wojtek-t let me know if you're ok with folding KEP 3838 into this PR, or prefer making it a separate one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm PRR approver for both, so I'm fine with a single PR - whatever works better for you.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Wei!

@Huang-Wei Huang-Wei mentioned this pull request Jan 29, 2024
Closed
@wojtek-t wojtek-t self-assigned this Jan 31, 2024
@ahg-g
Copy link
Member

ahg-g commented Jan 31, 2024

/lgtm
/approve

for sig-scheduling

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2024
@Huang-Wei Huang-Wei changed the title KEP 3521: graduate PodSchedulingReadiness to stable KEP 3521/3838: graduate PodSchedulingReadiness to stable Jan 31, 2024
wojtek-t
wojtek-t reviewed Feb 1, 2024
View reviewed changes
keps/sig-scheduling/3838-pod-mutable-scheduling-directives/README.md
- [ ] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
- [ ] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
- [x] User-facing documentation has been created in [kubernetes/website], for publication to [kubernetes.io]
- [x] Supporting documentation—e.g., additional design documents, links to mailing list discussions/SIG meetings, relevant PRs/issues, release notes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late now, but this question:

> Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?

No, will be tested manually when implementing the validation changes.

Should have been filled in before promoting to beta.

@wojtek-t
Copy link
Member

wojtek-t commented Feb 1, 2024

/lgtm
/approve PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, Huang-Wei, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@wojtek-t
Copy link
Member

wojtek-t commented Feb 1, 2024

/hold

Please ensure that issues are opted-in to milestone.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2024
@Huang-Wei
Copy link
Member Author

Please ensure that issues are opted-in to milestone.

#3521 and #3838 are opted-in to milestone v1.30.

@wojtek-t
Copy link
Member

wojtek-t commented Feb 1, 2024

#3521 and #3838 are opted-in to milestone v1.30.

@Huang-Wei - they are not - you need lead opted-in label, just the milestone is not enough

@Huang-Wei
Copy link
Member Author

@Huang-Wei - they are not - you need lead opted-in label, just the milestone is not enough

@wojtek-t is this good enough?

image

@wojtek-t
Copy link
Member

wojtek-t commented Feb 1, 2024

Yup - that works now.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8ac5215 into kubernetes:master Feb 1, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 1, 2024
@Huang-Wei Huang-Wei deleted the 3521-ga branch February 1, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@ahg-g ahg-g Awaiting requested review from ahg-g

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@wojtek-t wojtek-t

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Scheduling
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
4 participants
@Huang-Wei @ahg-g @wojtek-t @k8s-ci-robot