Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3335: Update stable milestone to 1.31 #4694

Merged
merged 1 commit into from
Jun 12, 2024
Merged

KEP-3335: Update stable milestone to 1.31 #4694

merged 1 commit into from
Jun 12, 2024
+44 −14

Conversation

pwschuurman
Copy link
Contributor

  • One-line PR description: KEP-3335: Update stable milestone to 1.31
  • Other comments: e2e tests will not be graduated (per the conformance criteria, as using the .spec.ordinals field is optional.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2024
@pwschuurman pwschuurman mentioned this pull request Jun 5, 2024
Open
18 tasks
@pwschuurman pwschuurman force-pushed the kep-3335-stable branch 3 times, most recently from 04644c3 to 2b3c7cb Compare June 5, 2024 06:48
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2024
@pwschuurman
Copy link
Contributor Author

Manual upgrade->downgrade->upgrade validation scenario: https://gist.github.com/pwschuurman/045d38aeb4f36181edc4f53b956843db

soltysh
soltysh approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
from sig-apps pov
/hold
for prr review

keps/sig-apps/3335-statefulset-slice/README.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 7, 2024
wojtek-t
wojtek-t reviewed Jun 7, 2024
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor quetion - other than that LGTM

keps/sig-apps/3335-statefulset-slice/README.md Show resolved Hide resolved
@wojtek-t wojtek-t self-assigned this Jun 11, 2024
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 11, 2024
@wojtek-t
Copy link
Member

/lgtm
/approve PRR

/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman, soltysh, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fd25970 into kubernetes:master Jun 12, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@soltysh soltysh soltysh approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@kow3ns kow3ns Awaiting requested review from kow3ns

Assignees

@soltysh soltysh

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
4 participants
@pwschuurman @wojtek-t @k8s-ci-robot @soltysh