KEP-4785: CRDMetrics Controller #4811
Conversation
rexagod
commented
Aug 27, 2024
rexagod
commented
- One-line PR description: This KEP proposes the incorporation of the CRDMetrics controller into the Kubernetes organization, similar to its existing counterpart for native metrics, Kube State Metrics.
- Issue link: Custom State Metrics Resource Controller #4785
- Other comments: Please refer to https://github.com/rexagod/crdmetrics for more details.
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rexagod The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
removed
the
approved
logicalhan
added
the
lead-opted-in
| Resource State API from Kube State Metrics, and replace it by the CRDMetrics | ||
| controller which, in addition to its own benefits, would allow Kube State | ||
| Metrics to drop all Custom Resource State API-specific behaviors that can crash | ||
| Kube State Metrics, directly affecting the availability of native metrics |
There was a problem hiding this comment.
There was a problem hiding this comment.
| - sig-instrumentation | ||
| status: implementable | ||
| creation-date: 2024-08-27 | ||
| reviewers: |
There was a problem hiding this comment.
let's add @mrueg as well if he has the bandwidth to review
There was a problem hiding this comment.
I honestly don't know how I missed that, let me fix this ASAP.
This KEP proposes the incorporation of the CRDMetrics controller into the Kubernetes organization, similar to its existing counterpart for native metrics, Kube State Metrics. Refer: https://github.com/rexagod/crdmetrics
| * while providing cluster-scoped managed resources (`CRDMetricsResource`) that | ||
| allows defining the collection configuration for generating metrics | ||
| on-the-fly, and, |
There was a problem hiding this comment.
🎉 This will be awesome. Having this as a CRD also makes the configuration versioned 👍
would be good to keep the API package which defines the type clean so importing it in other projects (e.g. https://github.com/kubernetes-sigs/controller-tools ) would not introduce other transitive dependencies.
I plan to add a generator for this in controller-tools so the config can be generated from markers just like the CRD itself.
Prior art regarding transitive dependencies for an API package:
