Skip to content

Commit

Permalink
add multiple packages at once
Browse files Browse the repository at this point in the history
  • Loading branch information
liggitt committed Oct 11, 2021
1 parent 2f65039 commit f9fdb52
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 18 deletions.
12 changes: 2 additions & 10 deletions args/args.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,16 +137,8 @@ func (g *GeneratorArgs) NewBuilder() (*parser.Builder, error) {
// Ignore all auto-generated files.
b.AddBuildTags(g.GeneratedBuildTag)

for _, d := range g.InputDirs {
var err error
if strings.HasSuffix(d, "/...") {
err = b.AddDirRecursive(strings.TrimSuffix(d, "/..."))
} else {
err = b.AddDir(d)
}
if err != nil {
return nil, fmt.Errorf("unable to add directory %q: %v", d, err)
}
if err := b.AddPackagePatterns(g.InputDirs...); err != nil {
return nil, err
}
return b, nil
}
Expand Down
32 changes: 24 additions & 8 deletions parser/parse.go
Original file line number Diff line number Diff line change
Expand Up @@ -230,18 +230,34 @@ func (b *Builder) addFile(pkgPath importPathString, path string, src []byte, use
return nil
}

// AddDir adds an entire directory, scanning it for go files. 'dir' should have
// a single go package in it. GOPATH, GOROOT, and the location of your go
// binary (`which go`) will all be searched if dir doesn't literally resolve.
func (b *Builder) AddDir(dir string) error {
_, err := b.importPackage(dir, true)
// AddPackagePatterns adds the specified patterns,
// which may be individual import paths as used in import directives,
// or recursive paths like `example.com/...`.
func (b *Builder) AddPackagePatterns(patterns ...string) error {
for _, d := range patterns {
var err error
if strings.HasSuffix(d, "/...") {
err = b.addPackageRecursive(strings.TrimSuffix(d, "/..."))
} else {
err = b.addPackage(d)
}
if err != nil {
return fmt.Errorf("unable to add directory %q: %v", d, err)
}
}
return nil
}

// addPackage adds an entire package, scanning it for go files.
func (b *Builder) addPackage(importPackage string) error {
_, err := b.importPackage(importPackage, true)
return err
}

// AddDirRecursive is just like AddDir, but it also recursively adds
// subdirectories; it returns an error only if the path couldn't be resolved;
// addPackageRecursive is just like addPackage, but it also recursively adds
// subpackages; it returns an error only if the path couldn't be resolved;
// any directories recursed into without go source are ignored.
func (b *Builder) AddDirRecursive(dir string) error {
func (b *Builder) addPackageRecursive(dir string) error {
// Add the root.
if _, err := b.importPackage(dir, true); err != nil {
klog.Warningf("Ignoring directory %v: %v", dir, err)
Expand Down

0 comments on commit f9fdb52

Please sign in to comment.