Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up worktree dirs during sync loop #418

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

thockin
Copy link
Member

@thockin thockin commented Jun 22, 2021

Avoid "already exists" error. This is a port of #412 but I changed
the e2e to use docker pause.

Avoid "already exists" error.  This is a port of kubernetes#412 but I changed
the e2e to use `docker pause`.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from stp-ip June 22, 2021 22:08
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2021
@barney-s
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit a8b0ace into kubernetes:master Jun 23, 2021
echo "$TESTCASE" > "$REPO"/file
git -C "$REPO" commit -qam "$TESTCASE"
GIT_SYNC \
--period=100ms \

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be --wait

@barney-s
Copy link

@thockin
Sorry pulled the trigger too early.
The parameter "--period" needs to be "--wait" ?

@thockin
Copy link
Member Author

thockin commented Jun 23, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants