Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump base bookworm image to 1.0.2 #871

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

dims
Copy link
Member

@dims dims commented Apr 10, 2024

Updated golang to 1.22 as well.

Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 10, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 10, 2024
@rikatz
Copy link

rikatz commented Apr 10, 2024

/lgtm

on my lunch time and saw on twitter :P

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2024
Copy link

@norrs norrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a very sane thing to do :-)
Hopefully latest debian-base contains the security fixes.

@thockin
Copy link
Member

thockin commented Apr 12, 2024

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, norrs, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit e695728 into kubernetes:master Apr 12, 2024
5 checks passed
@norrs
Copy link

norrs commented Apr 16, 2024

@thockin : My idea was that this would fix https://security-tracker.debian.org/tracker/CVE-2023-45853 , but reading more in details in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1054290 it seems like even tho zlib package itself does not build the minizip binary, it contains the sources for it that other source packages could vendor this again from zlib. In the bug report mentioned below, it seems like other packages have actually done this. 😅

I believe maybe https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1054290#64 has released a fix for debian unstable and trixie (current what is defined as debian next upcoming stable release). But current stable debian bookworm is not currently patched with a backport of the fix.

Should we maybe request a backport upstream in debian for bookworm? Because currently the security-tracker has the following note: [bookworm] - zlib <ignored> (contrib/minizip not built and producing binary packages), so I'm a bit unsure if this will get a follow up if we don't ask about it?

@thockin
Copy link
Member

thockin commented Apr 16, 2024

We can ask - I am not an expert in this sort of assessment, so I usually defer to Debian baseimage owners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants