Add ProviderConfig Controller #2792
Open
+752
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
2 times, most recently
from
8ca2383 to
64a3448
Compare
|
/retest |
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
from
64a3448 to
63b6cbe
Compare
|
/retest |
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
2 times, most recently
from
0c861ed to
fd75ee7
Compare
k8s-ci-robot
added
size/L
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
2 times, most recently
from
6fde296 to
717f4c9
Compare
|
Thanks @panslava! I'm yet to take a look, but glancing through: now that we've started making use of our libraries/packages, are there some useful unit / integration tests that we can add? |
cmd/glbc/main.go
Outdated
| namer, | ||
| stopCh, | ||
| ) | ||
| if err != nil { |
There was a problem hiding this comment.
This seems to be checking for the incorrect error
pkg/multiproject/start/start.go
Outdated
|
|
||
| informersFactory := informers.NewSharedInformerFactoryWithOptions(kubeClient, ctxConfig.ResyncPeriod) | ||
|
|
||
| providerConfigInformer := providerconfiginformers.NewSharedInformerFactory(providerConfigClient, ctxConfig.ResyncPeriod).Flags().V1().ProviderConfigs().Informer() |
There was a problem hiding this comment.
Who starts this informer?
There was a problem hiding this comment.
Add properly starting all informers
- Introduced a new ProviderConfigController to track ProviderConfig resources and start NEG controllers. - Added initialization and running the ProviderConfigController in multi-project mode in main.go.
…nt have specific purpose
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
from
12a0122 to
262703c
Compare
k8s-ci-robot
added
size/XL
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
from
00d673c to
013fb0a
Compare
|
Added unit tests Ready for review This PR has a bit too many commits now, integration tests will be done in next PR |
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
2 times, most recently
from
d887fd8 to
f413eeb
Compare
panslava
force-pushed
the
multi-project-cluster-slice-controller
branch
from
f413eeb to
1a7e4d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @gauravkghildiyal
This will be the very last to review