Skip to content

Commit

Permalink
Update comment about restart of pod
Browse files Browse the repository at this point in the history
  • Loading branch information
aledbf committed Jun 24, 2020
1 parent d7f7e16 commit 14acc18
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions internal/ingress/controller/nginx.go
Original file line number Diff line number Diff line change
Expand Up @@ -337,13 +337,9 @@ func (n *NGINXController) Start() {
return
}

// if the nginx master process dies the workers continue to process requests,
// passing checks but in case of updates in ingress no updates will be
// reflected in the nginx configuration which can lead to confusion and report
// issues because of this behavior.
// To avoid this issue we restart nginx in case of errors.
// if the nginx master process dies, the workers continue to process requests
// until the failure of the configured livenessProbe and restart of the pod.
if process.IsRespawnIfRequired(err) {
// release command resources
return
}

Expand Down

0 comments on commit 14acc18

Please sign in to comment.