Skip to content

Commit

Permalink
Fix publish-service patch and update README (#1867)
Browse files Browse the repository at this point in the history
  • Loading branch information
victortrac authored and aledbf committed Dec 31, 2017
1 parent cabd7cb commit 2b24494
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
8 changes: 4 additions & 4 deletions deploy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ Patch the nginx ingress controller deployment to add the flag `--publish-service

```console
kubectl patch deployment -n ingress-nginx nginx-ingress-controller --type='json' \
--patch="$(curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/patch-deployment.yaml)"
--patch="$(curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/publish-service-patch.yaml)"
```

For L4:
Expand Down Expand Up @@ -159,7 +159,7 @@ Patch the nginx ingress controller deployment to add the flag `--publish-service

```console
kubectl patch deployment -n ingress-nginx nginx-ingress-controller --type='json' \
--patch="$(curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/patch-deployment.yaml)"
--patch="$(curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/publish-service-patch.yaml)"
```

```console
Expand Down Expand Up @@ -187,7 +187,7 @@ Patch the nginx ingress controller deployment to add the flag `--publish-service

```console
kubectl patch deployment -n ingress-nginx nginx-ingress-controller --type='json' \
--patch="$(curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/patch-deployment.yaml)"
--patch="$(curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/publish-service-patch.yaml)"
```

```console
Expand Down Expand Up @@ -264,4 +264,4 @@ and is setup to be used in the deployment [without-rbac](without-rbac.yaml) or [
- --configmap=$(POD_NAMESPACE)/nginx-configuration
```

For information on using the config-map, see its [user-guide](../docs/user-guide/configmap.md).
For information on using the config-map, see its [user-guide](../docs/user-guide/configmap.md).
1 change: 0 additions & 1 deletion deploy/patch-deployment.yaml

This file was deleted.

7 changes: 7 additions & 0 deletions deploy/publish-service-patch.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
[
{
'op': 'add',
'path': '/spec/template/spec/containers/0/args/-',
'value': '--publish-service=$(POD_NAMESPACE)/ingress-nginx'
}
]

0 comments on commit 2b24494

Please sign in to comment.