Merge pull request #1739 from aledbf/cleanup-tests

Improve e2e checks
kubernetes · Nov 22, 2017 · 6657845 · 6657845
2 parents 51da945 + b6dfe3d
commit 6657845
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 19 deletions.
diff --git a/test/e2e/annotations/alias.go b/test/e2e/annotations/alias.go
@@ -19,7 +19,6 @@ package annotations
 import (
 	"fmt"
 	"net/http"
-	"strings"
 
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
@@ -78,8 +77,8 @@ var _ = framework.IngressNginxDescribe("Annotations - Alias", func() {
 
 		err = f.WaitForNginxServer(host,
 			func(server string) bool {
-				return strings.Contains(server, "server_name foo") &&
-					!strings.Contains(server, "return 503")
+				return Expect(server).Should(ContainSubstring("server_name foo")) &&
+					Expect(server).ShouldNot(ContainSubstring("return 503"))
 			})
 		Expect(err).NotTo(HaveOccurred())
 
@@ -139,8 +138,8 @@ var _ = framework.IngressNginxDescribe("Annotations - Alias", func() {
 
 		err = f.WaitForNginxServer(host,
 			func(server string) bool {
-				return strings.Contains(server, "server_name foo") &&
-					!strings.Contains(server, "return 503")
+				return Expect(server).Should(ContainSubstring("server_name foo")) &&
+					Expect(server).ShouldNot(ContainSubstring("return 503"))
 			})
 		Expect(err).NotTo(HaveOccurred())
 

diff --git a/test/e2e/annotations/auth.go b/test/e2e/annotations/auth.go
@@ -20,7 +20,6 @@ import (
 	"fmt"
 	"net/http"
 	"os/exec"
-	"strings"
 
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
@@ -54,8 +53,8 @@ var _ = framework.IngressNginxDescribe("Annotations - Alias", func() {
 
 		err = f.WaitForNginxServer(host,
 			func(server string) bool {
-				return strings.Contains(server, "server_name auth") &&
-					!strings.Contains(server, "return 503")
+				return Expect(server).Should(ContainSubstring("server_name auth")) &&
+					Expect(server).ShouldNot(ContainSubstring("return 503"))
 			})
 		Expect(err).NotTo(HaveOccurred())
 
@@ -83,8 +82,8 @@ var _ = framework.IngressNginxDescribe("Annotations - Alias", func() {
 
 		err = f.WaitForNginxServer(host,
 			func(server string) bool {
-				return strings.Contains(server, "server_name auth") &&
-					strings.Contains(server, "return 503")
+				return Expect(server).Should(ContainSubstring("server_name auth")) &&
+					Expect(server).Should(ContainSubstring("return 503"))
 			})
 		Expect(err).NotTo(HaveOccurred())
 
@@ -117,8 +116,8 @@ var _ = framework.IngressNginxDescribe("Annotations - Alias", func() {
 
 		err = f.WaitForNginxServer(host,
 			func(server string) bool {
-				return strings.Contains(server, "server_name auth") &&
-					!strings.Contains(server, "return 503")
+				return Expect(server).Should(ContainSubstring("server_name auth")) &&
+					Expect(server).ShouldNot(ContainSubstring("return 503"))
 			})
 		Expect(err).NotTo(HaveOccurred())
 
@@ -151,8 +150,8 @@ var _ = framework.IngressNginxDescribe("Annotations - Alias", func() {
 
 		err = f.WaitForNginxServer(host,
 			func(server string) bool {
-				return strings.Contains(server, "server_name auth") &&
-					!strings.Contains(server, "return 503")
+				return Expect(server).Should(ContainSubstring("server_name auth")) &&
+					Expect(server).ShouldNot(ContainSubstring("return 503"))
 			})
 		Expect(err).NotTo(HaveOccurred())
 
@@ -186,8 +185,8 @@ var _ = framework.IngressNginxDescribe("Annotations - Alias", func() {
 
 		err = f.WaitForNginxServer(host,
 			func(server string) bool {
-				return strings.Contains(server, "server_name auth") &&
-					!strings.Contains(server, "return 503")
+				return Expect(server).Should(ContainSubstring("server_name auth")) &&
+					Expect(server).ShouldNot(ContainSubstring("return 503"))
 			})
 		Expect(err).NotTo(HaveOccurred())
 
@@ -232,8 +231,8 @@ var _ = framework.IngressNginxDescribe("Annotations - Alias", func() {
 
 		err = f.WaitForNginxServer(host,
 			func(server string) bool {
-				return strings.Contains(server, "server_name auth") &&
-					!strings.Contains(server, "return 503")
+				return Expect(server).Should(ContainSubstring("server_name auth")) &&
+					Expect(server).ShouldNot(ContainSubstring("return 503"))
 			})
 		Expect(err).NotTo(HaveOccurred())
 

diff --git a/test/e2e/framework/framework.go b/test/e2e/framework/framework.go
@@ -26,6 +26,7 @@ import (
 	"k8s.io/client-go/kubernetes"
 	restclient "k8s.io/client-go/rest"
 
+	"github.com/golang/glog"
 	. "github.com/onsi/ginkgo"
 	. "github.com/onsi/gomega"
 )
@@ -215,7 +216,16 @@ func (f *Framework) matchNginxConditions(name string, matcher func(cfg string) b
 			return false, err
 		}
 
-		if matcher(o) {
+		var match bool
+		errs := InterceptGomegaFailures(func() {
+			if matcher(o) {
+				match = true
+			}
+		})
+
+		glog.V(2).Infof("Errors waiting for conditions: %v", errs)
+
+		if match {
 			return true, nil
 		}