Skip to content

Commit

Permalink
Merge pull request #1700 from aledbf/missing-publish-service
Browse files Browse the repository at this point in the history
Add patch command to append publish-service flag
  • Loading branch information
aledbf authored Nov 13, 2017
2 parents 870ee35 + 1ef283f commit 94487ca
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
21 changes: 21 additions & 0 deletions deploy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,13 @@ This setup requires to choose in which layer (L4 or L7) we want to configure the
- [Layer 4](https://en.wikipedia.org/wiki/OSI_model#Layer_4:_Transport_Layer): use TCP as the listener protocol for ports 80 and 443.
- [Layer 7](https://en.wikipedia.org/wiki/OSI_model#Layer_7:_Application_Layer): use HTTP as the listener protocol for port 80 and terminate TLS in the ELB

Patch the nginx ingress controller deployment to add the flag `--publish-service`

```console
kubectl patch deployment -n ingress-nginx nginx-ingress-controller --type='json' \
--patch="$(curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/patch-deployment.yaml)"
```

For L4:

```console
Expand Down Expand Up @@ -147,6 +154,13 @@ kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/mast

### GCE - GKE

Patch the nginx ingress controller deployment to add the flag `--publish-service`

```console
kubectl patch deployment -n ingress-nginx nginx-ingress-controller --type='json' \
--patch="$(curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/patch-deployment.yaml)"
```

```console
curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/provider/gce-gke/service.yaml \
| kubectl apply -f -
Expand All @@ -168,6 +182,13 @@ kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/mast

### Azure

Patch the nginx ingress controller deployment to add the flag `--publish-service`

```console
kubectl patch deployment -n ingress-nginx nginx-ingress-controller --type='json' \
--patch="$(curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/patch-deployment.yaml)"
```

```console
curl https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/provider/azure/service.yaml \
| kubectl apply -f -
Expand Down
1 change: 1 addition & 0 deletions deploy/patch-deployment.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[{'op': 'replace', 'path': '/spec/template/spec/containers/0/args', 'value':['/nginx-ingress-controller','--default-backend-service=$(POD_NAMESPACE)/default-http-backend','--configmap=$(POD_NAMESPACE)/nginx-configuration','--tcp-services-configmap=$(POD_NAMESPACE)/tcp-services','--udp-services-configmap=$(POD_NAMESPACE)/udp-services','--publish-service=$(POD_NAMESPACE)/ingress-nginx']}]

0 comments on commit 94487ca

Please sign in to comment.