Fix "invalid port in upstream" on nginx controller

kubernetes · Dec 14, 2016 · bda6646 · bda6646
1 parent 0af8ccc
commit bda6646
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/controllers/nginx/pkg/cmd/controller/metrics.go b/controllers/nginx/pkg/cmd/controller/metrics.go
@@ -42,7 +42,7 @@ func (em exeMatcher) MatchAndName(nacl common.NameAndCmdline) (bool, string) {
 func (n *NGINXController) setupMonitor(args []string) {
 	pc, err := newProcessCollector(true, exeMatcher{"nginx", args})
 	if err != nil {
-		glog.Fatalf("unexpedted error registering nginx collector: %v", err)
+		glog.Fatalf("unexpected error registering nginx collector: %v", err)
 	}
 	err = prometheus.Register(pc)
 	if err != nil {

diff --git a/core/pkg/ingress/controller/controller.go b/core/pkg/ingress/controller/controller.go
@@ -982,7 +982,7 @@ func (ic *GenericController) getEndpoints(
 			}
 
 			// check for invalid port value
-			if targetPort == -1 {
+			if targetPort <=0 {
 				continue
 			}