Skip to content

Commit

Permalink
Merge pull request #1520 from Gregy/optimize-alias
Browse files Browse the repository at this point in the history
Change alias behaviour not to create new server section needlessly
  • Loading branch information
aledbf authored Oct 12, 2017
2 parents a18daab + e78ad92 commit bf26abf
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
2 changes: 1 addition & 1 deletion configuration.md
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ For more information please check https://enable-cors.org/server_nginx.html
### Server Alias

To add Server Aliases to an Ingress rule add the annotation `ingress.kubernetes.io/server-alias: "<alias>"`.
This will create a server with the same configuration, but a different server_name as the provided host.
This will create a server with two server_names (hostname and alias)

*Note:* A server-alias name cannot conflict with the hostname of an existing server. If it does the server-alias
annotation will be ignored. If a server-alias is created and later a new server with the same hostname is created
Expand Down
16 changes: 1 addition & 15 deletions rootfs/etc/nginx/template/nginx.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -362,26 +362,12 @@ http {
{{ range $index, $server := $servers }}

server {
server_name {{ $server.Hostname }};
server_name {{ $server.Hostname }} {{ $server.Alias }};
{{ template "SERVER" serverConfig $all $server }}


{{ template "CUSTOM_ERRORS" $all }}
}

{{ if $server.Alias }}
server {
server_name {{ $server.Alias }};
{{ template "SERVER" serverConfig $all $server }}

{{ if not (empty $cfg.ServerSnippet) }}
# Custom code snippet configured in the configuration configmap
{{ $cfg.ServerSnippet }}
{{ end }}

{{ template "CUSTOM_ERRORS" $all }}
}
{{ end }}
{{ end }}

# default server, used for NGINX healthcheck and access to nginx stats
Expand Down

0 comments on commit bf26abf

Please sign in to comment.