Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canary split is not working if a separate ingress is going to the same canary service. #6230

Closed
christianjoun opened this issue Sep 25, 2020 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@christianjoun
Copy link

christianjoun commented Sep 25, 2020

NGINX Ingress controller version: nginx version 2.11.2 (ingress-nginx-2.11.2)

Kubernetes version (use kubectl version):

$ kubectl version
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.6", GitCommit:"dff82dc0de47299ab66c83c626e08b245ab19037", GitTreeState:"clean", BuildDate:"2020-07-15T16:58:53Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.8", GitCommit:"ec6eb119b81be488b030e849b9e64fda4caaf33c", GitTreeState:"clean", BuildDate:"2020-03-12T20:52:22Z", GoVersion:"go1.13.8", Compiler:"gc", Platform:"linux/amd64"}

Environment:

Cloud provider or hardware configuration: aws
OS (e.g. from /etc/os-release): PRETTY_NAME="Ubuntu 16.04.7 LTS"
Kernel (e.g. uname -a): Linux ip-10-93-160-95 4.15.0-115-generic #116~16.04.1-Ubuntu SMP Wed Aug 26 17:36:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Install tools:
Others:

What happened:

Assuming a spilt ingress of 50%. canary split is not work if a separate ingress is going to the same canary service.

Please include exact error messages if you can: seen this in the logs perhaps related

I0924 21:09:09.335721 7 controller.go:1074] Ingress ieng-training/canary-verification-split is marked as Canary, ignoring

What you expected to happen: Traffic splits 50%

What do you think went wrong?:

bug

How to reproduce it:

  1. create two backend services that respond with ("i am primary" or "i am canary")

backendService1: canary-verification (responds with "I am primary" on port 443 @ /v1/resource)
backendService2: canary-canary-verification (responds with I am canary" on port 443 @ /v1/resource)

  1. apply the there ingresses I attached

  2. use a debugPod in the cluster to curl -kI https://canary-verification.xxx.net/v1/resource

  3. observe no split. (only "i am primary" returns)

  4. delete resource canary-verification-canary.ingress.yaml (or edit resource canary-verification-canary.ingress.yaml L 17 to be serviceName: canary-verification-canary-non-existant)

  5. observe split starts working ("i am primary"/"i am canary")

canary-verification-split.ingress.txt
canary-verification.ingress.txt
canary-verification-canary.ingress.txt

@christianjoun christianjoun added the kind/bug Categorizes issue or PR as related to a bug. label Sep 25, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 23, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

3 participants