Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image versions #7320

Closed
rikatz opened this issue Jul 4, 2021 · 11 comments · Fixed by #7411
Closed

Update image versions #7320

rikatz opened this issue Jul 4, 2021 · 11 comments · Fixed by #7411
Assignees
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@rikatz
Copy link
Contributor

rikatz commented Jul 4, 2021

Some things are really old in our base image. We probably need/want to update some things, as LuaJIT2 and some modules.

The file with build process is: https://github.com/kubernetes/ingress-nginx/blob/master/images/nginx/rootfs/build.sh

We need to update each of those modules, create the image and check if something breaks.

For example, a process here should be:

  • Update all the versions and checksums in the script
  • make build (and then wait, and wait...or build now only for amd64 for the initial tests)
  • Change "Makefile" in root directory (ingress-nginx) to point to the new created image
  • Do a make kind-e2e-test and check if everything passes

/help

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 4, 2021
@iamNoah1
Copy link
Contributor

iamNoah1 commented Jul 6, 2021

/assign

@iamNoah1
Copy link
Contributor

iamNoah1 commented Jul 7, 2021

/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 7, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Jul 8, 2021

@iamNoah1 let me know if you need any help here :)

@iamNoah1
Copy link
Contributor

iamNoah1 commented Jul 9, 2021

@rikatz have to get my hands on it first but will get back to you as soon as I need help. Thx :)

@strongjz
Copy link
Member

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jul 17, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Aug 10, 2021

/reopen

@k8s-ci-robot
Copy link
Contributor

@rikatz: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Aug 10, 2021
@k8s-ci-robot
Copy link
Contributor

@rikatz: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 10, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Aug 10, 2021

kubernetes/k8s.io#2502 <- Image promotion
#7473 <- updating the images in Makefiles
kubernetes/k8s.io#2504 <- Images (test runner, etc) promoted

@strongjz
Copy link
Member

@rikatz @iamNoah1 I’m guessing we can close this one since those have been merged in #7473

We can always re-open.

/close

@k8s-ci-robot
Copy link
Contributor

@strongjz: Closing this issue.

In response to this:

@rikatz @iamNoah1 I’m guessing we can close this one since those have been merged in #7473

We can always re-open.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants