GCE: Fix retry of cloudprovider client generation #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
/assign @nikhiljindal |
|
/assign @bowei |
|
@bowei I'm not sure if we should keep this StatusForbidden check: https://github.com/nicksardo/ingress/blob/d59d5c4bf3392f89466f9d4546a68ff39dcf9cd7/controllers/gce/controller/cluster_manager.go#L229-L234 |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original code read an io.Reader from within a loop. If the first iteration errored (possibly due to an intermittent network issue), the second iteration would read an empty reader. Therefore, no config values would be passed in after the first iteration.