Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency github.com/paultag/sniff #1035

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Update dependency github.com/paultag/sniff #1035

merged 1 commit into from
Aug 4, 2017

Conversation

antoineco
Copy link
Contributor

The revision in Godeps.json doesn't exist (anymore?), so godep restore fails, which happened to me while importing this project as a dependency.

ref in Godeps.json does not exist
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 27, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 27, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.027% when pulling ba137f5 on antoineco:fix-godep-restore into 3495bfb on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Jul 27, 2017

@antoineco we use a fork divergentdave/sniff@558797a because the upstream version had an error that seems to be resolved now.

@nicksardo
Copy link
Contributor

@aledbf Are you saying we should redirect the dependency back to paultag?

@aledbf
Copy link
Member

aledbf commented Aug 1, 2017

@nicksardo I need to test the fix

@aledbf aledbf self-assigned this Aug 4, 2017
@aledbf
Copy link
Member

aledbf commented Aug 4, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2017
@aledbf
Copy link
Member

aledbf commented Aug 4, 2017

@antoineco thanks!

@aledbf aledbf merged commit faf80ad into kubernetes:master Aug 4, 2017
@antoineco antoineco deleted the fix-godep-restore branch August 31, 2017 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants