Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return reference to object providing Endpoint #1043

Merged
merged 1 commit into from
Aug 2, 2017
Merged

Return reference to object providing Endpoint #1043

merged 1 commit into from
Aug 2, 2017

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Jul 29, 2017

Summary

This adds a new field Target to the ingress.Endpoint type, which references the object providing that Endpoint.

Use case

I am writing a controller for Apache 2 and want to provide the ability to enable stickiness in front of Tomcat backends. The standard way to achieve this is to set the route= parameter for every BalancerMember (equivalent of upstream.server in nginx). This parameter must match the value of jvmRoute= on the backend.

Without a reference to the Pod providing the endpoint I can't reliably set a route Apache 2 and Tomcat can agree on, like the Pod's name.

ref: https://httpd.apache.org/docs/2.4/mod/mod_proxy_balancer.html#stickyness_implementation

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 29, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 44.105% when pulling 6035e55 on antoineco:ep-targetref into 65e8cec on kubernetes:master.

@aledbf aledbf self-assigned this Aug 2, 2017
@aledbf
Copy link
Member

aledbf commented Aug 2, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 2, 2017
@aledbf
Copy link
Member

aledbf commented Aug 2, 2017

@antoineco thanks!

@aledbf aledbf merged commit 1045e43 into kubernetes:master Aug 2, 2017
@antoineco antoineco deleted the ep-targetref branch August 31, 2017 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants