Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConfigMap's namespace in custom configuration example for nginx #1085

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

loicfrering
Copy link
Contributor

The configmap option --configmap=$(POD_NAMESPACE)/nginx-custom-configuration in the nginx-custom-configuration.yaml deployment expects the ConfigMap to be in the kube-system namespace but it was not set in the ConfigMap definition.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 8, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@loicfrering
Copy link
Contributor Author

I just signed the CLA :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 8, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.768% when pulling b469c19 on loicfrering:master into 1b41e80 on kubernetes:master.

@aledbf aledbf self-assigned this Aug 8, 2017
@aledbf
Copy link
Member

aledbf commented Aug 8, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2017
@aledbf
Copy link
Member

aledbf commented Aug 8, 2017

@loicfrering thanks!

@aledbf aledbf merged commit 27f447f into kubernetes:master Aug 8, 2017
@loicfrering
Copy link
Contributor Author

@aledbf You are very welcome, thanks a lot for your work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants