Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix move nested if statement #11688

Merged

Conversation

MrErlison
Copy link
Member

What this PR does / why we need it:

Adjust HTTP2MaxRequests by moving if statement out of nested block

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

/cc @rikatz

@k8s-ci-robot k8s-ci-robot requested a review from rikatz July 26, 2024 22:59
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 26, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2024
@rikatz
Copy link
Contributor

rikatz commented Jul 26, 2024

GOOD CATCH
/lgtm
/approve
Will merge this now

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrErlison, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@rikatz rikatz merged commit 0e0b366 into kubernetes:feature-go-crossplane Jul 26, 2024
8 of 10 checks passed
rikatz pushed a commit that referenced this pull request Sep 10, 2024
rikatz pushed a commit that referenced this pull request Sep 15, 2024
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Sep 29, 2024
rikatz pushed a commit that referenced this pull request Sep 29, 2024
rikatz pushed a commit that referenced this pull request Oct 3, 2024
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Oct 3, 2024
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Oct 28, 2024
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Nov 5, 2024
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Nov 11, 2024
rikatz pushed a commit to rikatz/ingress-nginx that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants