Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for opentracing #1384

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Add support for opentracing #1384

merged 1 commit into from
Sep 26, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 17, 2017 •
edited
Loading

fixes #1366

Test image: quay.io/aledbf/nginx-ingress-controller:0.224

Local zipkin:
docker run -d -p 9411:9411 openzipkin/zipkin

Configmap configuration:

apiVersion: v1
data:
  enable-opentracing: "true"
  zipkin-collector-host: 192.168.99.1

screenshot from 2017-09-17 21 11 28

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 43.919% when pulling 5a7ee73b57473525e288ee58ff1bba46d442596d on aledbf:opentracing into 1a68536 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 43.919% when pulling d38106f on aledbf:opentracing into 1a68536 on kubernetes:master.

@gianrubio
Copy link
Contributor

@aledbf amazing feature!!!
This project has a lot of features but not at all are documented. Could you add docs explaining how to use?

@aledbf aledbf changed the title WIP: Add support for opentracing Add support for opentracing Sep 26, 2017
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2017
@aledbf aledbf merged commit 47ea2d7 into kubernetes:master Sep 26, 2017
@aledbf aledbf deleted the opentracing branch September 26, 2017 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. nginx size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NGINX: add support for opentracing
5 participants
@aledbf @k8s-reviewable @coveralls @gianrubio @k8s-ci-robot